Check for image data before calling imagecreatefromstring() #34161
Conversation
The current code can run into a few conditions where the end result is that `imagecreatefromstring()` is called on something that isn't actually an image. I found two conditions where that happens. The first is where we end up with a NULL value at the end. The second is where a remote image is requested, but what you get back is something else ( like the HTML for an error page ). This update adds checks to defend against both of those possible error conditions.
Check for image before calling imagecreatefromstring()
github-actions
bot
added
the
[Plugin] Jetpack
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so: 🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so: 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
github-actions
bot
added
[Status] Needs Author Reply
|
@josephscott Since this PR is open on a fork, it doesn't come with the utilities we have to run checks, and quickly test that PR on WordPress.com Simple. I've consequently opened a new PR with your changes and a few more things in #34164. Could you give it a look? Thank you! |
github-actions
bot
removed
the
[Status] Needs Author Reply
The current code can run into a few conditions where the end result is that imagecreatefromstring() is called on something that isn't actually an image.
I found two conditions where that happens. The first is where we end up with a NULL value at the end. The second is where a remote image is requested, but what you get back is something else ( like the HTML for an error page ).
This update adds checks to defend against both of those possible error conditions.