Jetpack Social| Fix scheduled posts UI #34182

manzoorwanijk · 2023-11-17T10:58:36Z

This is the base branch for fixing scheduled posts UI for Jetpack Social

Proposed changes:

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

This is a base branch
Please test the individual brances

github-actions · 2023-11-17T10:59:26Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the feature/jetpack-social-scheduled-posts-ui branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack feature/jetpack-social-scheduled-posts-ui

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2023-11-17T10:59:36Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Social plugin:

Next scheduled release: January 2, 2024.
Scheduled code freeze: December 25, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

gmjuhasz

I found a minor issue. If you have 0 schedule shares, the bar looks wrong, it's not filling the space out. If I schedule at least 1 post it looks good.

manzoorwanijk · 2023-12-07T12:26:22Z

I found a minor issue. If you have 0 schedule shares, the bar looks wrong, it's not filling the space out. If I schedule at least 1 post it looks good.

Thank you for catching that. I have pushed a fix

gmjuhasz

Thanks for fixing that. I tested the scenarios and all seemed to work for me 👍

pablinos

I've mainly just scanned through the code again, but a lot of it has been reviewed as part of other PRs.

We should check a few scenarios, mainly with and without a plan on both the Jetpack and Social plugins. We should also test this on WPCOM. We've been seeing some conflicts with different versions of plugins active on sites too, so we should probably check this in that scenario too.

projects/js-packages/components/components/record-meter-bar/style.scss

projects/js-packages/publicize-components/src/components/form/enabled-connections-notice.tsx

projects/js-packages/publicize-components/src/components/form/index.js

projects/js-packages/publicize-components/src/components/share-limits-bar/index.tsx

projects/js-packages/publicize-components/src/hooks/use-share-limits/index.ts

projects/js-packages/publicize-components/src/social-store/types.ts

…hared if they will get over limits. (#34183) * Enhance RecordBarMeter component with `className` * Add changelog * Add store types * Update store selectors and actions * Update consumer hook to use new selectors * Create useShareLimits hook * Move `ShareCounter` to publicize-components and name it `ShareLimitsBar` * Create separate notice components * Fix the post editor notices * Update Jetpack Social admin page to use the new meter bar * Remove unused code left after #34111 * Add changelog * Fix share count * Update index.js * Include active connections count for notices * Fix i18n build error * Enhance RecordBarMeter component with `className` * Add changelog * Extract constants and improve types * Extract messages to utility function * Enhance RecordBarMeter component with `className` * Add changelog * Fix up versions * Revert "Remove unused code left after #34111" This reverts commit ca45999. * Use @wordpress/element instead of react * Fix messaging * Let TS infer type * Combine the share limits logic into a single useSelect call * Fix the limits shown even after a paid plan

* Enhance RecordBarMeter component with `className` * Add changelog * Add store types * Update store selectors and actions * Update consumer hook to use new selectors * Create useShareLimits hook * Move `ShareCounter` to publicize-components and name it `ShareLimitsBar` * Create separate notice components * Fix the post editor notices * Update Jetpack Social admin page to use the new meter bar * Remove unused code left after #34111 * Add changelog * Fix share count * Update index.js * Include active connections count for notices * Fix i18n build error * Enhance RecordBarMeter component with `className` * Add changelog * Extract constants and improve types * Add types/jest * Add tests for sharesData selectors * Add tests for useShareLimits hook * rename to *.test.js * extract utility * Create add-tests-for-sharing-data * Update shares-data.test.js * Extract messages to utility function * Use the messages from utility function * Enhance RecordBarMeter component with `className` * Add changelog * Fix up versions * Revert "Remove unused code left after #34111" This reverts commit ca45999. * Use @wordpress/element instead of react * Fix messaging * Let TS infer type * Combine the share limits logic into a single useSelect call * Fix the limits shown even after a paid plan * Enhance RecordBarMeter component with `className` * Add changelog * Enhance RecordBarMeter component with `className` * Add changelog * Jetpack Social | Warn the user that their scheduled posts won't get shared if they will get over limits. (#34183) * Enhance RecordBarMeter component with `className` * Add changelog * Add store types * Update store selectors and actions * Update consumer hook to use new selectors * Create useShareLimits hook * Move `ShareCounter` to publicize-components and name it `ShareLimitsBar` * Create separate notice components * Fix the post editor notices * Update Jetpack Social admin page to use the new meter bar * Remove unused code left after #34111 * Add changelog * Fix share count * Update index.js * Include active connections count for notices * Fix i18n build error * Enhance RecordBarMeter component with `className` * Add changelog * Extract constants and improve types * Extract messages to utility function * Enhance RecordBarMeter component with `className` * Add changelog * Fix up versions * Revert "Remove unused code left after #34111" This reverts commit ca45999. * Use @wordpress/element instead of react * Fix messaging * Let TS infer type * Combine the share limits logic into a single useSelect call * Fix the limits shown even after a paid plan * Update tests

* Update store selectors and resolvers to save initial connections * Update useShareLimits hook to subtract scheduled post if editing one * Update ShareCountInfo to subtract the scheduled post from count * Add changelog * Fix versions * changelog!!!!

* Make share data selectors independent of the connections * Enhance RecordMeterBar component * Enhance ShareLimitsBar component * Pass connections data to useShareLimits * Update editor form components * Update social admin page header * Add support for providing text variant * Add enabledConnections to used/scheduled number * Fix enabledConnections being NaN * Update the notice and meter to match the new designs/logic. * Update the admin page header component * Fix tests * Revert changes to RecordBarMeter * Revert an unnecessary change to RecordMeterBar * Add changelog * Create update-share-limits-bar-design * Fix "msgid argument is not a string literal" build error 100th time in Jetpack * Fix "Optimization seems to have broken the following translation strings" - "left" * Revert "Fix "Optimization seems to have broken the following translation strings" - "left"" This reverts commit d1d7cda. * Use "remaining" instead of "left" for the sake of passing the build * Fix "Optimization seems to have broken the following translation strings - "left"" build error * Simplify share limits bar logic * Clean up unused logic * Restore outOfConnections logic * Fix unit tests * Clean up types.ts * Update notice CTA design * Use "or" instead of "and" * Fix the bar title and caption * Fix "Optimization seems to have broken the following translation strings" * Fix typo * Make it a minor change instead of a patch * Add enabled connections text * Remove padding for the bar on Social admin page * Fix up versions * When under the limits, show an inline upgrade nudge instead of notice * Revert "When under the limits, show an inline upgrade nudge instead of notice" This reverts commit b0b1909. * Fix the order of the title and notice * Clean things up a bit --------- Co-authored-by: Gergely Juhasz <[email protected]> Co-authored-by: Paul Bunkham <[email protected]>

spsiddarthan

Tests well!

manzoorwanijk added the DO NOT MERGE don't merge it! label Nov 17, 2023

manzoorwanijk self-assigned this Nov 17, 2023

github-actions bot added [JS Package] Components [Status] In Progress RNA labels Nov 17, 2023

manzoorwanijk mentioned this pull request Nov 17, 2023

Jetpack Social | Warn the user that their scheduled posts won't get shared if they will get over limits. #34183

Merged

3 tasks

manzoorwanijk force-pushed the feature/jetpack-social-scheduled-posts-ui branch from ea04d2f to f46952a Compare November 20, 2023 05:45

manzoorwanijk mentioned this pull request Nov 20, 2023

Add unit tests for sharing data store #34206

Merged

3 tasks

manzoorwanijk force-pushed the feature/jetpack-social-scheduled-posts-ui branch 3 times, most recently from 51c428c to d55655d Compare November 22, 2023 06:51

github-actions bot added [JS Package] Publicize Components [Package] Publicize [Plugin] Social Issues about the Jetpack Social plugin [Tests] Includes Tests labels Nov 22, 2023

manzoorwanijk force-pushed the feature/jetpack-social-scheduled-posts-ui branch 4 times, most recently from f5ba835 to 073a3df Compare November 28, 2023 04:42

manzoorwanijk mentioned this pull request Nov 28, 2023

Jetpack Social | Fix scheduled post double count #34323

Merged

3 tasks

manzoorwanijk force-pushed the feature/jetpack-social-scheduled-posts-ui branch 2 times, most recently from dfb3268 to 078d13c Compare November 30, 2023 06:38

manzoorwanijk force-pushed the feature/jetpack-social-scheduled-posts-ui branch from 88db9dc to 4ea62b0 Compare December 7, 2023 10:42

manzoorwanijk added the [Status] Needs Team Review label Dec 7, 2023

manzoorwanijk requested a review from a team December 7, 2023 10:47

manzoorwanijk marked this pull request as ready for review December 7, 2023 10:47

gmjuhasz reviewed Dec 7, 2023

View reviewed changes

gmjuhasz previously approved these changes Dec 7, 2023

View reviewed changes

manzoorwanijk dismissed gmjuhasz’s stale review via d62caa3 December 7, 2023 12:47

manzoorwanijk force-pushed the feature/jetpack-social-scheduled-posts-ui branch from d62caa3 to f8a15bb Compare December 7, 2023 12:59

pablinos reviewed Dec 8, 2023

View reviewed changes

manzoorwanijk force-pushed the feature/jetpack-social-scheduled-posts-ui branch from f914126 to f8c2557 Compare December 11, 2023 06:04

manzoorwanijk requested a review from pablinos December 11, 2023 09:57

manzoorwanijk and others added 16 commits December 12, 2023 15:08

Enhance RecordBarMeter component with className

10817d7

Add changelog

7d95bc2

Use boolean instead of number

4bef795

Fix up versions

b1819fb

Fix up versions and lockfile

5d9b10f

Fix the bar width

ba8b316

Fix TS build

8c3090f

Restore dependencies messed up while resolving conflicts.

ef4583f

Restore the record meter bar styles

6d55b2b

Make the bar go red after 90% usage

404cc2a

Use "connection" instead of "network"

8f99dac

Hide connections text when publicize is OFF

8e120f3

manzoorwanijk force-pushed the feature/jetpack-social-scheduled-posts-ui branch from 0621d9a to 8e120f3 Compare December 12, 2023 09:39

Fix up versions

0082968

manzoorwanijk enabled auto-merge (squash) December 12, 2023 10:11

spsiddarthan approved these changes Dec 13, 2023

View reviewed changes

manzoorwanijk merged commit 5858f1e into trunk Dec 13, 2023
66 checks passed

manzoorwanijk deleted the feature/jetpack-social-scheduled-posts-ui branch December 13, 2023 07:40

github-actions bot removed [Status] In Progress [Status] Needs Team Review labels Dec 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jetpack Social| Fix scheduled posts UI #34182

Jetpack Social| Fix scheduled posts UI #34182

manzoorwanijk commented Nov 17, 2023 •

edited

Loading

github-actions bot commented Nov 17, 2023 •

edited

Loading

github-actions bot commented Nov 17, 2023 •

edited

Loading

gmjuhasz left a comment

manzoorwanijk commented Dec 7, 2023

gmjuhasz left a comment

pablinos left a comment

spsiddarthan left a comment

Jetpack Social| Fix scheduled posts UI #34182

Jetpack Social| Fix scheduled posts UI #34182

Conversation

manzoorwanijk commented Nov 17, 2023 • edited Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Nov 17, 2023 • edited Loading

github-actions bot commented Nov 17, 2023 • edited Loading

gmjuhasz left a comment

Choose a reason for hiding this comment

manzoorwanijk commented Dec 7, 2023

gmjuhasz left a comment

Choose a reason for hiding this comment

pablinos left a comment

Choose a reason for hiding this comment

spsiddarthan left a comment

Choose a reason for hiding this comment

manzoorwanijk commented Nov 17, 2023 •

edited

Loading

github-actions bot commented Nov 17, 2023 •

edited

Loading

github-actions bot commented Nov 17, 2023 •

edited

Loading