-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost: Add "load default strings" to excludes in concatenate UI #40496
base: trunk
Are you sure you want to change the base?
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Boost plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things, but looks good otherwise.
projects/plugins/boost/app/assets/src/js/features/minify-meta/minify-meta.tsx
Outdated
Show resolved
Hide resolved
className={ styles.button } | ||
variant="link" | ||
> | ||
{ __( 'Load default strings', 'jetpack-boost' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd much rather we didn't use "strings" here or in the sub header. Yes, they literally are strings, but they're the handles used to register JS and CSS files. Strings describes what those pixels on the screen are, not what they do or represent
.
Maybe use "scripts" instead? "JS Scripts" "CSS Scripts" ?
I'm not sure. Could be a job for another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. The values aren't just strings. They are handles. I'd suggest calling them "default handles" as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind calling them handles, I'm worried that a lot of users have no idea what that means. We're mentioning strings everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed in 34fde9b
.
We should probably change the labels as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have looked more carefully at the modules.
In the JS module:
- "Scripts" is used to describe the files loaded.
- The toggle says, "Exclude JS Strings".
- The sub header says, "Exclude JS Strings".
In the CSS module:
- "Styles" is used to describe the files loaded.
- The toggle says, "Exclude CSS Strings".
- The sub header says, "Exclude CSS Strings".
This patch adds a button saying, "Load default handles".
Would it be better to use "scripts" in the JS module, and "styles" in the CSS module? This is what it might look like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we drop "Scripts/Styles" from the label and just say "Exclude JS" or "Exclude CSS".
Then we could update the description to say "handles" and maybe add a link to a support article that mentions how to identify those? Then the button will be "Load default handles".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense when I say "JS scripts" out loud, as in "JavaScript scripts". It's a bit cumbersome.
I'd go one step further and change that last string to "Load Defaults" too. No need to confuse the user with new jargon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd go one step further and change that last string to "Load Defaults" too.
Funny you should say that. I intentionally added what is being loaded (hence the strings
part), since @haqadn pointed out that it's not clear what "Load defaults" loads when using the button when I initially added it to the dashboard in Cornerstone Pages.
Now I'm confused 😅
I also think we're getting a bit carried away with details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think handle is fine considering this terminology is coming WP itself, Example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the UI accordingly in 04a0dfd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I did make some changes. Since I am the one who made the latest changes, leaving the approval to others.
Rationale behind my commit (b2c5854):
I wanted to keep the stores for CSS and JS separate. This will allow us to easily move the store registrations to individual modules, which we need to do soon.
Proposed changes:
Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
no
Testing instructions: