Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Assistant: Add Jetpack AI module and disable all features when the module is disabled #40532

Open
wants to merge 23 commits into
base: trunk
Choose a base branch
from

Conversation

dhasilva
Copy link
Contributor

@dhasilva dhasilva commented Dec 9, 2024

Fixes #38461

Proposed changes:

  • Removes the "New" chip on the AI Assistant entry on the settings page
  • Adds a Jetpack AI module
  • Reacts to changes on the Jetpack AI module enabled value and activates or deactivates the AI features
  • Do not enqueue assets if the module was disabled at page load

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to the block editor
  • Check that the AI extensions are working as expected
  • Open another tab and go to wp-admin/admin.php?page=jetpack_modules
  • Find Jetpack AI and disable it
  • Refresh the editor (the change from another tab is not reflected on this tab's state)
  • Check that all Jetpack AI features are disabled. That includes the AI Assistant block, paragraph, heading, list, form, logo and image extensions, featured image and the sidebar features, as the sidebar itself is removed
  • Go to wp-admin/admin.php?page=jetpack#/writing
  • Enable Jetpack AI by clicking on Add Jetpack AI to your site and post editors
  • Refresh the editor again
  • Check that Jetpack AI features are enabled
  • On the browser's console, use: wp.data.dispatch('jetpack-modules').updateJetpackModuleStatus( { name: 'ai', active: false } )
  • Check that the AI features are disabled without a need for a page refresh, except for the AI Assistant block
  • Use wp.data.dispatch('jetpack-modules').updateJetpackModuleStatus( { name: 'ai', active: true } )
  • Check that the AI features are enabled without a need for a page refresh
  • Disable the module again and reload the page
  • Use wp.data.dispatch('jetpack-modules').updateJetpackModuleStatus( { name: 'ai', active: true } )
  • Check that the features are not enabled, as the assets were not loaded
  • Reload the page
  • Check that the AI features are enabled

Screenshot from 2024-12-12 16-09-12
Screenshot from 2024-12-12 16-08-57

@dhasilva dhasilva added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review labels Dec 9, 2024
@dhasilva dhasilva requested review from jeherve and a team December 9, 2024 22:53
@dhasilva dhasilva self-assigned this Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/jetpack-ai-module-dynamic branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/jetpack-ai-module-dynamic
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Block] AI Assistant [JS Package] AI Client [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Admin Page React-powered dashboard under the Jetpack menu RNA labels Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for January 7, 2025 (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AI Assistant panel is displayed when the module is off:

image

Maybe we can keep the panel visible, but display an invitation to turn on the module like we do for Publicize for example?

projects/plugins/jetpack/modules/ai.php Outdated Show resolved Hide resolved
projects/plugins/jetpack/modules/ai.php Outdated Show resolved Hide resolved
@github-actions github-actions bot added the [Extension] External Media Extend all block editor media tools to support external providers label Dec 10, 2024
@dhasilva dhasilva changed the title AI Assistant: Add Jetpack AI module and disable extensions when it is disabled AI Assistant: Add Jetpack AI module and disable all features when the module is disabled Dec 12, 2024
mwatson
mwatson previously approved these changes Dec 12, 2024
Copy link
Contributor

@mwatson mwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's working great! Tested on JN and had no issues with the module. :shipit:

CGastrell
CGastrell previously approved these changes Dec 12, 2024
Copy link
Contributor

@CGastrell CGastrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nice! Thanks! :shipit:

@dhasilva dhasilva dismissed stale reviews from CGastrell and mwatson via 903b162 December 12, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Block] AI Assistant [Extension] AI Assistant Plugin [Extension] AI Content Lens [Extension] External Media Extend all block editor media tools to support external providers [JS Package] AI Client [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA [Status] Needs Team Review [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "new" Chip from Seettings AI link
4 participants