-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect: Update onboarding popover placement #40550
Protect: Update onboarding popover placement #40550
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Protect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
/> | ||
) } | ||
{ !! status && ! isScanInProgress( status ) && hasPlan && ( | ||
<OnboardingPopover | ||
id={ 'paid-understand-severity' } | ||
anchor={ scanResultsAnchor } | ||
position={ 'top right' } | ||
position={ 'top' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't really an ideal position for this one given that the Severity
field is in the table and can be moved/removed, going with the a more general approach here of just pointing at the table centred above it.
@@ -119,7 +119,7 @@ const ScanAdminSectionHero: React.FC = () => { | |||
</Text> | |||
<OnboardingPopover | |||
id={ hasPlan ? 'paid-daily-and-manual-scans' : 'free-daily-scans' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At one point, I believe this paid popover pointed at the Scan Now
button - seems clear enough where it is currently highlighting the lastCheckedLocalTimestamp
, but is this something we maybe want to re-establish, if possible?
322819d
to
48fba20
Compare
064a3a3
to
578ae12
Compare
578ae12
to
e7cd983
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #
Updates the placement of onboarding popovers to account for changes made in the UI with introduction of the
ThreastDataViews
component.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Screen Captures
Free - Desktop:
Free - Mobile:
Paid - Desktop:
Paid - Mobile