Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect: Update onboarding popover placement #40550

Merged

Conversation

dkmyta
Copy link
Contributor

@dkmyta dkmyta commented Dec 10, 2024

Fixes #
Updates the placement of onboarding popovers to account for changes made in the UI with introduction of the ThreastDataViews component.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Load this branch of Protect in JT
  • Proceed through the free onboarding flow and verify popover location is clear/sufficient
  • Proceed through the paid onboarding flow and verify popover location is clear/sufficient

Screen Captures

Free - Desktop:
Screen Capture on 2024-12-10 at 09-56-14

Free - Mobile:
Screen Capture on 2024-12-10 at 09-57-09

Paid - Desktop:
Screen Capture on 2024-12-10 at 09-49-49

Paid - Mobile
Screen Capture on 2024-12-10 at 09-51-42

@github-actions github-actions bot added [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress labels Dec 10, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/protect

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

/>
) }
{ !! status && ! isScanInProgress( status ) && hasPlan && (
<OnboardingPopover
id={ 'paid-understand-severity' }
anchor={ scanResultsAnchor }
position={ 'top right' }
position={ 'top' }
Copy link
Contributor Author

@dkmyta dkmyta Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't really an ideal position for this one given that the Severity field is in the table and can be moved/removed, going with the a more general approach here of just pointing at the table centred above it.

@@ -119,7 +119,7 @@ const ScanAdminSectionHero: React.FC = () => {
</Text>
<OnboardingPopover
id={ hasPlan ? 'paid-daily-and-manual-scans' : 'free-daily-scans' }
Copy link
Contributor Author

@dkmyta dkmyta Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At one point, I believe this paid popover pointed at the Scan Now button - seems clear enough where it is currently highlighting the lastCheckedLocalTimestamp, but is this something we maybe want to re-establish, if possible?

@dkmyta dkmyta marked this pull request as ready for review December 10, 2024 18:02
@nateweller nateweller force-pushed the add/protect/core branch 3 times, most recently from 322819d to 48fba20 Compare December 15, 2024 03:29
@nateweller nateweller force-pushed the update/protect/onboarding-popover-placement branch from 064a3a3 to 578ae12 Compare December 15, 2024 03:40
@nateweller nateweller force-pushed the update/protect/onboarding-popover-placement branch from 578ae12 to e7cd983 Compare December 15, 2024 03:40
Copy link
Contributor

@nateweller nateweller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nateweller nateweller added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] In Progress labels Dec 15, 2024
@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 15, 2024
@nateweller nateweller merged commit a877b8c into add/protect/core Dec 15, 2024
51 of 52 checks passed
@nateweller nateweller deleted the update/protect/onboarding-popover-placement branch December 15, 2024 18:39
@github-actions github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Ready to Merge Go ahead, you can push that green button! labels Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants