Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts: Adding a theme provider #40558

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Charts: Adding a theme provider #40558

merged 6 commits into from
Dec 11, 2024

Conversation

grzegorz-cp
Copy link
Contributor

Fixes https://github.com/Automattic/jetpack-roadmap/issues/2041

Proposed changes:

  • extending Automattic Charts with a theme provider, allowing for easier chart adoption
  • replacing hard-coded colours in the chart components

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • install Jetpack packages if needed (this PR doesn't add new packages) pnpm i
  • navigate to the directory and run storybook: cd projects/js-packages/charts and pnpm run storybook
  • verify that existing charts are working and new theme provider is available
  • verify that different themes load different colours

SCR-20241211-mwct

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 11, 2024
annacmc
annacmc previously approved these changes Dec 11, 2024
Copy link
Contributor

@annacmc annacmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, I love it. Added one small, non-blocking, thought/question but otherwise it all works as expected and is very cool. Thank you for working on this 🙌

*/
const jetpackTheme: ChartTheme = {
backgroundColor: '#FFFFFF',
colors: [ '#98C8DF', '#006DAB', '#A6DC80', '#1F9828', '#FF8C8F' ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we import color vars from color-studio for these themes, or would that be adding unnecessary extra dependencies?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'll add a task to check this and see how/if we can leverage CSS variables for it.

CodeyGuyDylan
CodeyGuyDylan previously approved these changes Dec 11, 2024
Copy link
Contributor

@CodeyGuyDylan CodeyGuyDylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

@grzegorz-cp grzegorz-cp dismissed stale reviews from CodeyGuyDylan and annacmc via aa716ab December 11, 2024 21:13
@grzegorz-cp grzegorz-cp merged commit 6be299d into trunk Dec 11, 2024
55 checks passed
@grzegorz-cp grzegorz-cp deleted the add/charts-themes branch December 11, 2024 21:28
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants