-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starter page templates: correctly insert the pattern to the Content block #40583
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
9bba275
to
1acb3d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely! Nice work @fushar
Context: p1733852360016879-slack-CBTN58FTJ
Proposed changes:
In Gutenberg 19.8, we started defaulting to
template-locked
rendering mode when creating a new page with this PR:This breaks the Starter Page Templates feature in wpcom at this line:
jetpack/projects/packages/jetpack-mu-wpcom/src/features/starter-page-templates/page-patterns-plugin.tsx
Line 97 in 3c012a8
because in
template-locked
mode, the blocks includes the template parts, so the post content block might be buried in the middle inside some Group blocks.This PR fixes that by recursively finding the Content block.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: