Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack AI: Add thumbs up/down component to AI logo generator #40610

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

mwatson
Copy link
Contributor

@mwatson mwatson commented Dec 13, 2024

Fixes #40572

Proposed changes:

  • Adds the thumbs up/thumbs down rating component to the logo generator

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Slack thread about some limitations: p1734103605310639-slack-C054LN8RNVA
PS with designs: p1HpG7-uzm-p2

Does this pull request change what data or activity we track or use?

Nope

Testing instructions:

  • Check out the branch and rebuild as usual
  • Create a new post, insert a logo block, and use the AI logo generator to generate a new logo or browse your existing logos
  • Verify that there are no thumbs next to the "Use on block" button
  • Enable the feature:
define( 'JETPACK_BLOCKS_VARIATION', 'beta' );
add_filter( 'ai_response_feedback_enabled', '__return_true' );
  • Reload your post and open the logo generator again
  • Verify that a thumbs up/down appears next to the "Use on block" button
  • You should be able to click on the thumbs up or down and observe that the thumb changes color
  • Viewing other logos you have should show their rating (which will likely be no rating), and if you go back to a logo you already rated the same rating should be present.
  • Additionally: when you click the thumbs up or down you should be able to observe Tracks events that submit the rating, blog ID, and a type parameter that should be logo-generator
  • You can enter localStorage.setItem('debug', '*') in the console to see the above events

Limitation

See the Slack thread linked above. Once you close the logo generator the ratings are not preserved because they are not persisted anywhere that we can easily read from. So rating some logos, and then closing and re-opening the generator will cause all the logos will show up as unrated again. I have created an issue if we want to go back and fix (or patch) this, but I don't believe it's a high priority.

#40611

Screenshot

Screenshot 2024-12-13 at 1 56 31 PM

Copy link
Contributor

Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete.

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for January 7, 2025 (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@mwatson mwatson requested a review from a team December 13, 2024 18:59
@github-actions github-actions bot added [Extension] AI Assistant Plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant