-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack AI: Add thumbs up/down component to AI logo generator #40610
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete. |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Fixes #40572
Proposed changes:
Other information:
Jetpack product discussion
Slack thread about some limitations: p1734103605310639-slack-C054LN8RNVA
PS with designs: p1HpG7-uzm-p2
Does this pull request change what data or activity we track or use?
Nope
Testing instructions:
type
parameter that should belogo-generator
localStorage.setItem('debug', '*')
in the console to see the above eventsLimitation
See the Slack thread linked above. Once you close the logo generator the ratings are not preserved because they are not persisted anywhere that we can easily read from. So rating some logos, and then closing and re-opening the generator will cause all the logos will show up as unrated again. I have created an issue if we want to go back and fix (or patch) this, but I don't believe it's a high priority.
#40611
Screenshot