Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "wordpress-dataviews-snapshot" package #40612

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Dec 13, 2024

Proposed changes:

This package contains a snapshot build of @wordpress/dataviews/wp and metadata needed to have @wordpress/dependency-extraction-webpack-plugin extract the dependency, all in a manner that should work even if multiple plugins include different versions of the package.

This also updates the monorepo config to encourage use of this package instead of attempting to use @wordpress/dataviews directly.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

#39907

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • For the moment, the build is going to fail thanks to ThreatsDataViews being in js-packages/components. If we decide to go ahead with this approach, that will have to be addressed somehow.

This package contains a snapshot build of `@wordpress/dataviews/wp` and
metadata needed to have `@wordpress/dependency-extraction-webpack-plugin`
extract the dependency, all in a manner that should work even if
multiple plugins include different versions of the package.

This also updates the monorepo config to encourage use of this package
instead of attempting to use `@wordpress/dataviews` directly.
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Copy link
Contributor

Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete.

@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant