-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "wordpress-dataviews-snapshot" package #40612
base: trunk
Are you sure you want to change the base?
Conversation
This package contains a snapshot build of `@wordpress/dataviews/wp` and metadata needed to have `@wordpress/dependency-extraction-webpack-plugin` extract the dependency, all in a manner that should work even if multiple plugins include different versions of the package. This also updates the monorepo config to encourage use of this package instead of attempting to use `@wordpress/dataviews` directly.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete. |
Proposed changes:
This package contains a snapshot build of
@wordpress/dataviews/wp
and metadata needed to have@wordpress/dependency-extraction-webpack-plugin
extract the dependency, all in a manner that should work even if multiple plugins include different versions of the package.This also updates the monorepo config to encourage use of this package instead of attempting to use
@wordpress/dataviews
directly.Other information:
Jetpack product discussion
#39907
Does this pull request change what data or activity we track or use?
No
Testing instructions:
js-packages/components
. If we decide to go ahead with this approach, that will have to be addressed somehow.