fix(document): surface errors in subdoc pre validate

Fix #7187
Automattic · Nov 2, 2018 · 8f16b67 · 8f16b67
1 parent 87005a1
commit 8f16b67
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/schema/documentarray.js b/lib/schema/documentarray.js
@@ -164,8 +164,11 @@ DocumentArray.prototype.doValidate = function(array, fn, scope, options) {
     // them :(
 
     function callback(err) {
-      if (err) {
+      if (err != null) {
         error = err;
+        if (error.name !== 'ValidationError') {
+          error.$isArrayValidatorError = true;
+        }
       }
       --count || fn(error);
     }

diff --git a/test/document.test.js b/test/document.test.js
@@ -6379,11 +6379,11 @@ describe('document', function() {
 
   it('surfaces errors in subdoc pre validate (gh-7187)', function() {
     const InnerSchema = new Schema({ name: String });
-    
+
     InnerSchema.pre('validate', function() {
       throw new Error('Oops!');
     });
-    
+
     const TestSchema = new Schema({ subdocs: [InnerSchema] });
 
     const Test = db.model('gh7187', TestSchema);