fix(model): avoid hanging on empty bulkWrite() with ordered: false
#13684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested review from
Uzlopak,
hasezoey,
AbdelrahmanHafez and
IslandRhythms
AbdelrahmanHafez
approved these changes
Aug 1, 2023
|
Thanks for the fix! |
hasezoey
approved these changes
Aug 2, 2023
JavaScriptBach
added a commit
to JavaScriptBach/mongoose
that referenced
this pull request
Aug 4, 2023
vkarpov15
added a commit
that referenced
this pull request
Aug 6, 2023
Backport empty bulkwrite fix #13684 to Mongoose v6
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13664
Summary
Looks like if
bulkWrite()is empty andordered: false, we never hit theif (--remaining <= 0)check, sobulkWrite()hangs forever. Fixed in this PR, but likely worth doing some refactoring to switch to using async functions rather than callbacks internally withinbulkWrite()to avoid this sort of issue.Examples