-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cursor): throw error in ChangeStream constructor if changeStreamThunk()
throws a sync error
#14846
Merged
+43
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Thunk()` throws a sync error
hasezoey
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me.
Though some of the replica-set runs (both push & pull_request) had failed with: (which i assume has nothing todo with this PR in particular)
1) transactions
distinct (gh-8006):
MongoServerError: Given transaction number 4 does not match any in-progress transactions. The active transaction number is 3
at Connection.sendCommand (node_modules/mongodb/lib/cmap/connection.js:290:27)
at runMicrotasks (<anonymous>)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async Connection.command (node_modules/mongodb/lib/cmap/connection.js:313:26)
at async Server.command (node_modules/mongodb/lib/sdam/server.js:167:29)
at async InsertOneOperation.executeCommand (node_modules/mongodb/lib/operations/command.js:73:16)
at async InsertOneOperation.execute (node_modules/mongodb/lib/operations/insert.js:37:16)
at async InsertOneOperation.execute (node_modules/mongodb/lib/operations/insert.js:46:21)
at async executeOperation (node_modules/mongodb/lib/operations/execute_operation.js:136:16)
at async Collection.insertOne (node_modules/mongodb/lib/collection.js:154:16)
@hasezoey correct, looks like a flakey test |
This was referenced Sep 25, 2024
This was referenced Sep 25, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An unintended consequence of #14813 using promises rather than event emitters is that sync errors in
changeStreamThunk()
aren't possible to handle.Model.watch().on('error')
doesn't work because the constructor throws an error before theon('error')
call happens.This PR makes
ChangeStream()
constructor throw an error ifchangeStreamThunk()
throws a synchronous error. The code is a little clunky, but at least avoids silently ignoring sync errors inchangeStreamThunk()
. This code is hard to test becausechangeStreamThunk()
doesn't throw in Mongoose in general.Examples