Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add styles to fix braintree modal appearance #2036

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR will be ready to go after Automattic/newspack-plugin#3692 is merged. It makes Braintree's credit card form look closer to other payment processors.

How to test the changes in this Pull Request:

  1. Start on a test site running Braintree, and that the Braintree credit card is enabled as a payment processor.
  2. Apply this PR and run npm run build.
  3. Run through a test checkout and confirm that the Braintree credit cart form looks similar to Stripe and other payment gateways:

CleanShot 2025-01-27 at 12 22 06

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant