fix(cli): verify-reader CLI command #3660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoo
added
the
[Status] Needs Review
miguelpeixe
approved these changes
Jan 9, 2025
github-actions
bot
added
[Status] Approved
|
I had the same thought, but the way the command is written you could actually pass any flag and it will work... |
|
Hey @dkoo, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
matticbot
pushed a commit
that referenced
this pull request
Jan 10, 2025
## [5.10.7-alpha.1](v5.10.6...v5.10.7-alpha.1) (2025-01-10) ### Bug Fixes * **cli:** verify-reader CLI command ([#3660](#3660)) ([c639af7](c639af7)) * **recaptcha:** replace alerts with generic errors ([#3627](#3627)) ([44ef2d2](44ef2d2)) ### Performance Improvements * **data-events:** queue dispatches to execute on shutdown ([#3616](#3616)) ([510a1a0](510a1a0))
|
🎉 This PR is included in version 5.10.7-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jan 14, 2025
# [5.12.0-alpha.1](v5.11.1...v5.12.0-alpha.1) (2025-01-14) ### Bug Fixes * **cli:** verify-reader CLI command ([#3660](#3660)) ([c639af7](c639af7)) * **recaptcha:** replace alerts with generic errors ([#3627](#3627)) ([44ef2d2](44ef2d2)) * remove newspack_corrections_ids meta ([#3675](#3675)) ([dad258b](dad258b)) ### Features * **corrections:** add corrections and clarifications behind feature flag ([#3638](#3638)) ([ea745cf](ea745cf)) ### Performance Improvements * **data-events:** queue dispatches to execute on shutdown ([#3616](#3616)) ([510a1a0](510a1a0))
|
🎉 This PR is included in version 5.12.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jan 20, 2025
# [5.12.0](v5.11.3...v5.12.0) (2025-01-20) ### Bug Fixes * **cli:** verify-reader CLI command ([#3660](#3660)) ([c639af7](c639af7)) * **recaptcha:** replace alerts with generic errors ([#3627](#3627)) ([44ef2d2](44ef2d2)) * remove newspack_corrections_ids meta ([#3675](#3675)) ([dad258b](dad258b)) * **wcs:** migrate-expired-subscriptions handle manual subscriptions ([#3663](#3663)) ([e0f32e8](e0f32e8)) ### Features * **corrections:** add corrections and clarifications behind feature flag ([#3638](#3638)) ([ea745cf](ea745cf)) ### Performance Improvements * **data-events:** queue dispatches to execute on shutdown ([#3616](#3616)) ([510a1a0](510a1a0))
|
🎉 This PR is included in version 5.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Fixes the
wp newspack verify-readerCLI command:--useris a global flag and can't be used as an associative arg for specific commandsHow to test the changes in this Pull Request:
trunk, runwp newspack verify-reader --user=<user ID or email address>and observe that it fails with an error:wp newspack verify-reader --user-id=<user ID or email address>with both a user ID and an email address and confirm that it works as expected. (Note the new flag name--user-idinstead of--user)Other information: