Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(corrections): replace deprecated sanitize method #3694

Merged
merged 2 commits into from
Jan 23, 2025
Merged

fix(corrections): replace deprecated sanitize method #3694

merged 2 commits into from
Jan 23, 2025

Conversation

chickenn00dle
Copy link
Contributor

@chickenn00dle chickenn00dle commented Jan 23, 2025 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

See https://a8c.slack.com/archives/C07LB7B14GZ/p1737646629319029?thread_ts=1736808604.571439&cid=C07LB7B14GZ

This PR replaces the deprecated FILTER_SANITIZE_STRING sanitize flag with FILTER_SANITIZE_FULL_SPECIAL_CHARS.

How to test the changes in this Pull Request:

  1. Smoke test corrections location behavior (See feat(corrections): add corrections and clarifications behind feature flag #3638 for testing instructions for this)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 23, 2025
@chickenn00dle chickenn00dle requested a review from a team as a code owner January 23, 2025 16:14
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 23, 2025
@chickenn00dle chickenn00dle merged commit ce50e24 into trunk Jan 23, 2025
8 checks passed
@chickenn00dle chickenn00dle deleted the fix/replace-deprecated-sanitize-function branch January 23, 2025 17:10
@github-actions GitHub Actions
Copy link

Hey @chickenn00dle, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Jan 23, 2025
@semantic-release-bot
chore(release): 5.13.0-alpha.1 [skip ci]
3dc5275 
# [5.13.0-alpha.1](v5.12.2...v5.13.0-alpha.1) (2025-01-23)

### Bug Fixes

* add supported gateways check ([#3650](#3650)) ([74f7773](74f7773))
* **corrections:** replace deprecated sanitize method ([#3694](#3694)) ([ce50e24](ce50e24))
* remove support for legacy form checkout ([#3691](#3691)) ([46a3c16](46a3c16))
* **wcs:** expire manual subscriptions after on-hold duration ([#3681](#3681)) ([658416c](658416c))

### Features

* add custom bylines ([#3667](#3667)) ([3f45a6f](3f45a6f))
* rate limit checkout attempts ([#3678](#3678)) ([d275524](d275524))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.13.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

Assignees
No one assigned
Labels
released on @alpha [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chickenn00dle @matticbot @dkoo