Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor E2E tests initialization #270

Merged
merged 6 commits into from
Jun 19, 2024
Merged

Refactor E2E tests initialization #270

merged 6 commits into from
Jun 19, 2024

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jun 18, 2024 •
edited
Loading

Related to #258, as it can help address some issues spotted on Windows.

Proposed Changes

  • Before this change, the app ran by the E2E tests used local data which can interfere with the test logic. To avoid this and run E2E tests in isolation, we override the path functions to point to a temporal folder.
  • The before/after logic of the E2E tests has been reduced and simplified, as of now all tests start from a clean slate.

Testing Instructions

CI

  • Observe that all CI jobs pass.

Local

  • Run command npm run package.
  • Run command npm run e2e.
  • Observe that all E2E tests pass.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@fluiddot fluiddot requested review from a team June 18, 2024 18:05
@fluiddot fluiddot self-assigned this Jun 18, 2024
@fluiddot fluiddot force-pushed the update/refactor-e2e-tests-initialization branch from 8a9a4f5 to 3f7758f Compare June 18, 2024 18:07
dcalhoun
dcalhoun approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great improvement for test stability. Well done! 👏🏻

e2e/sites.test.ts Outdated Show resolved Hide resolved
@fluiddot fluiddot merged commit 7e3c4e4 into trunk Jun 19, 2024
10 checks passed
@fluiddot fluiddot deleted the update/refactor-e2e-tests-initialization branch June 19, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees

@fluiddot fluiddot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @dcalhoun