Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio: Include showDomainStep in the Create new site button URL #774

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

ivan-ottinger
Copy link
Contributor

Related issues

Proposed Changes

  • include showDomainStep in the Create new site button URL

Testing Instructions

  1. Check out the PR and build the app with npm start.
  2. Navigate to a local site that hasn't been connected to a WPCOM site.
  3. Open the Sync tab and click on the Create new site button.
  4. The browser window should open the Choose a domain step and should let you follow through the WPCOM site creation flow without any issues.

ℹ️ Please note there is a couple of existing styling issues on the Choose a domain step in Calypso which I am planning to look at next week.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@ivan-ottinger ivan-ottinger self-assigned this Jan 3, 2025
@ivan-ottinger ivan-ottinger requested a review from a team January 3, 2025 17:12
Copy link
Contributor

@fredrikekelund fredrikekelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants