Blockbase: Move block styles to theme.json #3958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
I'm running the latest from GB trunk and blockbase is not showing fontfamily for ol/ul:
|
scruffian
force-pushed
the
blockbase/update-list-styles
branch
from
8d5b0b9 to
d69cbcb
Compare
|
I changed the approach here. We don't need to declare the font at all, since themes can just use theme.json when they want to change it now. There are also some new templates that come from rebuilding the child themes which should have happened in a different PR. |
|
Looks like the related PR was closed in favor of this one. |
scruffian
force-pushed
the
blockbase/update-list-styles
branch
2 times, most recently
from
9747fb8 to
cf3f846
Compare
scruffian
force-pushed
the
blockbase/update-list-styles
branch
from
cf3f846 to
f82c2b1
Compare
|
This is rebased and good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
We can set list typography in the theme.json now, we don't need to do it in custom, so this is just a simplification.