-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blockbase: Update Blockbase and children to use flex #4468
Conversation
dfaf85a
to
3e58ee4
Compare
Mmmh, I think the gap was only applying initially to the normal layout, not the flex one (so it's actually a vertical gap between blocks inside a container, not horizontal) |
|
Looks like Quadrat's header is affected by this (here): |
Good catch. Updated it! |
blockbase/theme.json
Outdated
"spacing": { | ||
"blockGap": "var(--wp--custom--margin--horizontal)" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be too big:
This is also applying vertically to blocks inside layout inherit groups. The rule coming from here.
I think GB should have two different gap values for the two different layouts, since inherit is going to be separating vertically and flex is horizontal, which usually means smaller blocks of text that don't need such a big gap between them.
19e322b
to
58521a1
Compare
I've updated this to use the vertical margin everywhere. Ideally we'd be able to control the horizontal and vertical separately but for now I think this is an OK compromise. Tracking here: WordPress/gutenberg#34347 |
58521a1
to
e8f5f13
Compare
I just realized that and deleted my comment. :P |
No one will know :D |
I can't find anything else that doesn't look correct. I believe this is ready to come in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🚢
Thanks for finishing this one off @pbking |
Changes proposed in this Pull Request:
Since https://github.com/WordPress/gutenberg/pull/33359/files merged we can use the flex property of the group block to achieve this layout. The
blockGap
setting doesn't seem to be working in my tests.Related issue(s):
#4463