Blockbase: Use new attributes for navigation block #4832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
scruffian
force-pushed
the
update/navigation-block-attributes
branch
from
0966f7e to
c9fa5f6
Compare
This was referenced Nov 2, 2021
Closed
|
Looks like wpcom is ready for this change (Gutenberg has been updated enough to support it). However there are a few conflicts to address first. |
pbking
force-pushed
the
update/navigation-block-attributes
branch
from
227cc93 to
eb98151
Compare
|
Rebased and addressed conflicts. |
pbking
force-pushed
the
update/navigation-block-attributes
branch
from
eb98151 to
9214373
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
When WordPress/gutenberg#35568 merges we will need to update the attributes of the navigation block from:
"isResponsive": trueto:
"overlayMenu":"mobile".Except in videomaker where it should be:
"overlayMenu":"always".Related issue(s):
WordPress/gutenberg#35568