-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote: Core block settings #5574
Conversation
remote/style.css
Outdated
@@ -97,13 +97,100 @@ body > .is-root-container, | |||
padding-left: var(--wp--custom--spacing--outer); | |||
} | |||
|
|||
/* Button styles */ | |||
.wp-block-search__button, | |||
.wp-block-button__link, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, for example to target the buttons added in the editor using "Buttons" block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they are controlled by the theme.json file, so they don't need to be targetted here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you remove the right line? I thought it was wp-block-button__link
we should remove...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so
I think with the latest commit the border issue should be solved. |
remote/style.css
Outdated
} | ||
|
||
:is( | ||
a, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be fixed with the last commit
Changes proposed in this Pull Request:
Related issue(s):
Remote: Core block settings