Refactor/blockbase color admin #6043
Conversation
blockbase/styles/featured-one.json
Outdated
| @@ -0,0 +1,36 @@ | |||
| { | |||
| "version": 2, | |||
| "title": "Featured One", | |||
There was a problem hiding this comment.
@beafialho should we rename these color palettes/variations?
There was a problem hiding this comment.
Are these the Videomaker ones?
There was a problem hiding this comment.
These are the Blockbase color "schemes" from the customizer converted to theme variations. They didn't have names in Blockbase, just pictures and the "featured" label and I used the names that we had given them in configuration. As user-surfaced names they are certainly lack-luster.
There was a problem hiding this comment.
Oh, I see! Here's what I suggest then:
Default > Ocean Breeze
Featured (Red) > Ruby Wine
Featured (Green) > Rainforest
Featured (Pastel Colors) > Charcoal
There was a problem hiding this comment.
Thanks! Nice names. :)
There was a problem hiding this comment.
Thanks! Perhaps that's already showing but "Default" show "Ocean Breeze" instead.
| array( | ||
| 'type' => 'hidden', | ||
| 'description' => '<div class="notice notice-warning"> | ||
| <p>' . __( 'Color customization is now available exclusively in the Full Site Editor Global Styles panel. (Colors>Palette>⋮>Edit Colors) <br><br>Featured Palettes can now be found in the Full Site Editor as Theme Variations. (Browse Styles)', 'blockbase' ) . '</p> |
There was a problem hiding this comment.
This is a tiny nitpick, but should there be a colon (:>) here? (Colors>Palette>⋮>Edit Colors)
There was a problem hiding this comment.
No, it's supposed to be the three dots menu, not a colon. I wasn't sure how else to describe that. :P
There was a problem hiding this comment.
Ooh yeah! Hmm, I'm not sure of a better way to describe it either.
There was a problem hiding this comment.
there is a unicode character ⋮
Refactor/blockbase color admin (#6043) Moved templates from old folder location to new (#6073) Blockbase: Implement the Button elements API (#6041) Blockbase: Implement Comment Block and removed CSS (#6080) Fix/migrate blockbase font self hosted (#6123) Blockbase children: update comments block (#6153) Blockbase: Changed the trigger to render social icons (#6079) Blockbase: move button padding styles from ponyfill to theme.json (#5901) Co-authored-by: Grant Kinney <[email protected]> Co-authored-by: Jeremy Yip <[email protected]> Co-authored-by: MaggieCabrera <[email protected]> Co-authored-by: madhusudhand <[email protected]>
|
Closing: Work merged in #6167 |
Changes proposed in this Pull Request:
Note: Variations do NOT inherit from the parent. This means that any child theme that does NOT provide theme variations will not have Blockbase's. Child themes that did NOT provide palette collections would have been provided Blockbase's in the Customizer.
This change should not BREAK any themes, however any child themes should migrate their palettes to variations to continue to provide that functionality.
All of the public (and Videomaker) blockbase themes have been refactored (Geologist, Quadrat, Zoologist and Videomaker)
Related issue(s):
NOTE: This should be merged and released at the same time as the Font Customization refactor and released as a Major Point Release for the Blockbase theme.