Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote: move link styles to theme.json #6176

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Remote: move link styles to theme.json #6176

merged 3 commits into from
Nov 7, 2022

Conversation

madhusudhand
Copy link
Member

@madhusudhand madhusudhand commented Jul 11, 2022 •
edited
Loading

Changes proposed in this Pull Request:

Move the link pseudo state styles to theme.json

Testing instructions

  1. Activate remote theme
  2. Verify Link and navigation styles. They should work same as trunk on :hover, :active and :focus.
  3. Also, verify the same for other style variations.

Note: This would be a breaking change before WP 6.1

Related issue(s):

#6108

@madhusudhand madhusudhand added the [Theme] Remote Automatically generated label for Remote. label Jul 11, 2022
@madhusudhand madhusudhand self-assigned this Jul 11, 2022
matiasbenedetto
matiasbenedetto approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@matiasbenedetto matiasbenedetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good. I'm just adding a commit setting again the removed text-decoration-thickness but in theme.json.

remote/style.css Show resolved Hide resolved
@matiasbenedetto
Copy link
Member

Moving to "Approved but not mergeable" until theme.json link elements API makes to WordPress core.

@pbking pbking added this to the WordPress Core 6.1 milestone Jul 22, 2022
@madhusudhand madhusudhand merged commit 010a91d into trunk Nov 7, 2022
@madhusudhand madhusudhand deleted the remote-link-state-styles branch November 7, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasbenedetto matiasbenedetto matiasbenedetto approved these changes

Assignees

@madhusudhand madhusudhand

Labels
[Theme] Remote Automatically generated label for Remote.
Projects
None yet
Milestone
WordPress Core 6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@madhusudhand @matiasbenedetto @pbking @mikachan