Try/cleanup buttons css #6714
Merged
Try/cleanup buttons css #6714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
I noticed the file block button looked slightly different on hover with this PR - it was showing an underline. I've fixed this in the theme.json file here: 1d6b08f
I also noticed the theme.json was using version 1, so I've updated this to version 2 (although I know that's not part of this update..)
Otherwise, looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR is a copy of #6042 to trunk
We are removing the CSS that is now covered by the elements API implementation in #6041. The buttons on the search block, file block and button block should look the same as before.
I decided to leave the mixins as they are, in case they are used in other child themes, while removing the includes from Blockbase itself. I'm keeping all the hover stuff so we are not breaking anyone's themes either until that is supported by theme.json too.