Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset translate() transform on radio buttons in label purchase modal #2385

Merged
merged 3 commits into from
Mar 16, 2021

Conversation

waclawjacek
Copy link
Contributor

@waclawjacek waclawjacek commented Mar 16, 2021

Description

Due to a change introduced in Gutenberg, WCS&T radio button dot is now offset by several px. This commit introduces a transform: none CSS rule reverting this behavior.

Related issue(s)

Fixes #2380, #2321.

Steps to reproduce & screenshots/GIFs

Checklist

  • unit tests
  • changelog.txt entry added

Due to a change introduced in Gutenberg, WCS&T radio button dot is now
offset by several px. This commit introduces a `transform: none` CSS
rule reverting this behavior.
@waclawjacek waclawjacek self-assigned this Mar 16, 2021
@Ferdev Ferdev self-requested a review March 16, 2021 18:31
@waclawjacek
Copy link
Contributor Author

I have tested this on WordPress 5.7 and WooCommerce 5.1.0 on:

  • Firefox 86.0.1,
  • Chrome 89.0.4389.82,
  • Safari 14.0.3,

And on mobile:

  • Firefox,
  • Safari,
  • Chrome.

And then again on the above browsers but this time on WP 5.6 and WooCommerce 5.0.0-beta.2 which was reported as problematic in #2321.

@waclawjacek waclawjacek linked an issue Mar 16, 2021 that may be closed by this pull request
Copy link
Contributor

@Ferdev Ferdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Working for both WordPress 5.6.2 and 5.7

@Ferdev
Copy link
Contributor

Ferdev commented Mar 16, 2021

This PR also fixes #2321.

@Ferdev Ferdev merged commit 4f40a8b into develop Mar 16, 2021
@Ferdev Ferdev deleted the fix/2380-radio-button-rendering branch March 16, 2021 18:52
Ferdev added a commit that referenced this pull request Mar 16, 2021
@Ferdev Ferdev mentioned this pull request Mar 16, 2021
harriswong pushed a commit that referenced this pull request Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering problem with label purchase modal checkboxes Radio button display issue on Rates step
2 participants