Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: phpcbf and phpcs will now check against WP and WC standards #2749

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Chore: phpcbf and phpcs will now check against WP and WC standards #2749

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
531ef92
phpcbf and phpcs will now check against WP and WC standards
harriswong Jun 17, 2024
5c007e6
Update wp-coding-standards to 3.0+
harriswong Jun 18, 2024
bde649d
Update coding-standards/wpcs woocommerce/woocommerce-sniffs squizlabs…
harriswong Jun 19, 2024
e64fd2d
Update phpcodesniffer-composer-installer
harriswong Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions bin/wc-phpcbf
View file
Open in desktop

This file was deleted.

10 changes: 10 additions & 0 deletions bin/wc-phpcbf.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
#!/bin/sh

# phpcbf returns exit-code as 1 even if all errors were fixed.
# https://github.com/squizlabs/PHP_CodeSniffer/issues/3057#issuecomment-919794895

composer run phpcbf $@

status=$?

[ $status -eq 1 ] && exit 0 || exit $status
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@
"phpunit"
],
"phpcs": [
"phpcs -s -p"
"./vendor/bin/phpcs -s -p --ignore=vendor,.git,assets,node_modules,dist,docker,release,bin --standard=WooCommerce-Core,WordPress-Core,WordPress-Extra"
],
"phpcbf": [
"phpcbf -p"
"./vendor/bin/phpcbf -p --ignore=vendor,.git,assets,node_modules,dist,docker,release,bin --standard=WooCommerce-Core,WordPress-Core,WordPress-Extra "
],
"check-security": [
"./vendor/bin/phpcs . --ignore=vendor,.git,assets,node_modules,dist,docker,release,bin --standard=./.phpcs.security.xml --report-full --report-summary"
Expand Down
2 changes: 1 addition & 1 deletion lint-staged.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ module.exports = {
'npm run eslint:fix',
],
'*.php': [
'bin/wc-phpcbf',
'sh bin/wc-phpcbf.sh',
],
};
Loading