Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Block] Navigation - Improve hierarchical display of Overlay Submenus that are justified center or right #75576

Open
cuemarie opened this issue Apr 11, 2023 · 3 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". Navigation [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Enhancement [Type] Feature Request Feature requests User Report This issue was created following a WordPress customer report

Comments

@cuemarie
Copy link

cuemarie commented Apr 11, 2023

What

When the Navigation Block is justified center, it's submenu items appear very similar to parent menu items, unlike when the nav block is justified left or right. This is most noticeable on submenus with additional submenus, where padding/spacing make things look even harder to distinguish.

  1. On a site with a block theme, set up a Navigation Block > Submenu > Child Menu Links + Another Submenu > Child Menu Links
  2. Justify the Navigation block center
  3. Set the Settings > Overlay Menu to "Mobile"
  4. Save and view the site on a mobile device or in a browser using Responsive Design Mode

The Submenu's child items in the overlay aren't noticeably different than parent items, with some confusing spacing that makes it hard to tell what is a child item and what is a parent item.

Why

Some sites put quite a bit of hierarchical organization into their menus, with the intention of helping their visitors find the content they need. This organization is lost, and the result can be quite confusing to look at.

Examples

Desktop View of Menu with submenu hierarchy

Markup on 2023-04-11 at 11:34:53

How the Overlay menu works if the menu is Justified LEFT or RIGHT

Markup on 2023-04-11 at 11:34:14
The hierarchy of the menu is preserved on the overlay menu.

Overlay menu when Justified CENTER

Markup 2023-04-11 at 11 34 35

Notice how "Submenu 2", which is a child of the "Getting Started" parent item, appears just under the child items of Submenu 1, obscuring the hierarchy. Further, the odd padding between elements makes things harder to follow.

How

This seems to touch on a few different factors:

Update - A core request was submitted here as well: WordPress/gutenberg#45612

@cuemarie cuemarie added [Type] Feature Request Feature requests [Type] Enhancement Navigation [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. labels Apr 11, 2023
@cuemarie cuemarie added the User Report This issue was created following a WordPress customer report label Apr 11, 2023
@cuemarie
Copy link
Author

@mdtanjid0 reported this issue here: #75549 for a user following this interaction: 6133315-zen

@github-actions
Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 6133315-zen

@cuemarie cuemarie added [Pri] Normal Schedule for the next available opportuinity. Triaged To be used when issues have been triaged. labels Apr 11, 2023
@masperber masperber changed the title [Block] Navigation - Improve hierarchical display of Overlay Submenus that are justified center [Block] Navigation - Improve hierarchical display of Overlay Submenus that are justified center or right Apr 24, 2024
@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Apr 24, 2024
@masperber
Copy link

I think there is also need for improvement of the display when the hierarchical menu is justified to the right.

Here is a screen capture of a hierarchical menu justified to the right on an FSE theme as of April 2024. In the image, the top-level menu items appear to the far right. Sub-menu items appear indented to the left.

I received customer feedback that this display looks strange, and I agree that to someone who is used to reading text left to right it does look strange, and hard to determine what is a top-level menu item and what is a submenu item.

Annotation on 2024-04-24 at 18-23-08

The flip side of this is how to give support to people who use languages that read right to left, but I think those languages might find the appearance on left-indent as similarly strange.

I think the Navigation Block needs more customization options. For instance, it would be useful to be able to justify items one way for the non-overlay menu and another way for the overlay menu. It would also be useful to be able to have greater control over the appearance of the overlay menu, such as padding around the left and right sides of the links, and controlling how the sub-menu items are indented with respect to the top-level menu items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". Navigation [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Enhancement [Type] Feature Request Feature requests User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests

2 participants