Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation block's responsive modal can't be customized #34514

Closed
Tracked by #35521
iandunn opened this issue Sep 2, 2021 · 1 comment
Closed
Tracked by #35521

Navigation block's responsive modal can't be customized #34514

iandunn opened this issue Sep 2, 2021 · 1 comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.

Comments

@iandunn
Copy link
Member

iandunn commented Sep 2, 2021

What problem does this address?

I'd like to be able to implement a design like the following, where the responsive menu doesn't take over the entire screen, and contains more than just links:

Screen Shot 2021-09-02 at 3 36 14 PM

That doesn't seem possible right now, unless I resort to an ugly hack like filtering render_block.

For now I've turned off Enable responsive menu, and am building the open/close functionality myself. That's not too awful, but it'd be ideal if the contents could be customized without having to do that.

What is your proposed solution?

Maybe support a block-template-parts/responsive-navigation.html template?

I'm open to other ideas as well.

@getdave
Copy link
Contributor

getdave commented Mar 17, 2023

Closing in favour of #38201 where there is more discussion on the same topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants