Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Searching for a page causes page to go blank #95243

Closed
rw-ye opened this issue Oct 9, 2024 · 10 comments
Closed

Site Editor: Searching for a page causes page to go blank #95243

rw-ye opened this issue Oct 9, 2024 · 10 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. Groundskeeping Issues handled through Dotcom Groundskeeping rotations Needs triage Ticket needs to be triaged [Platform] Atomic [Platform] Simple [Pri] BLOCKER Requires immediate attention. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Type] Bug

Comments

@rw-ye
Copy link

rw-ye commented Oct 9, 2024

Quick summary

When searching for a page in the "Pages" section of the site editor, it causes the entire page to go blank. I can consistently reproduce on both AT and Simple sites.

Video:

Screen.Recording.2024-10-09.at.7.41.23.pm.mov

Steps to reproduce

  1. Make sure you have a FSE theme active.
  2. Navigate to the site editor (Appearance > Editor)
  3. Select "Pages"
  4. Search for a page
  5. The entire page will go blank

What you expected to happen

To be able to search for a page

What actually happened

The entire page goes blank

Impact

Most (> 50%)

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

The workaround is to use the "Pages" section on the site dashboard instead.

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

No response

@rw-ye rw-ye added [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Full Site Editor The site editor. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Bug Needs triage Ticket needs to be triaged labels Oct 9, 2024
@rw-ye rw-ye added the [Pri] Normal Schedule for the next available opportuinity. label Oct 9, 2024
@Robertght Robertght moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Oct 9, 2024
@Robertght Robertght added [Pri] BLOCKER Requires immediate attention. and removed [Pri] Normal Schedule for the next available opportuinity. labels Oct 9, 2024
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Oct 9, 2024
@Robertght
Copy link

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated
  • Replicable outside of Dotcom – No

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Console errors:

Image

📌 ACTIONS

  • Triaged
  • Marking this as Blocker

Weirdly, another similar thing I found yesterday but more specific to mobile use: #95072

@sejas sejas added the Groundskeeping Issues handled through Dotcom Groundskeeping rotations label Oct 9, 2024
@sejas
Copy link
Member

sejas commented Oct 9, 2024

I can reproduce the issue on simple and atomic when searching

Image

I see the same error in console:

TypeError: Cannot read properties of undefined (reading 'id')
    at iS (index.min.js?m=1726663399i&ver=088cb1de53fe673a60d6:120:948)
    at index.min.js?m=1726663399i&ver=088cb1de53fe673a60d6:100:15607
    at index.min.js?m=1726663399i&ver=088cb1de53fe673a60d6:100:15902
    at index.min.js?m=1726663399i&ver=088cb1de53fe673a60d6:100:16007
    at Vr (VM45 react-dom.min.js:1:73191)
    at Cl (VM45 react-dom.min.js:1:92835)
    at dl (VM45 react-dom.min.js:1:85243)
    at Nn (VM45 react-dom.min.js:1:32432)
    at VM45 react-dom.min.js:1:91667
    at El (VM45 react-dom.min.js:1:91672)

I tested it on a non WPcom site and I see a similar behaviour in core. When searching a page the whole page turns "gray" and stays like that until the user clicks anywhere. The biggest difference is that WPcom throws an error in console and "crashes".

error-searching-pages-JN-core.webm

@sejas
Copy link
Member

sejas commented Oct 9, 2024

I've tested a regular site (non WPcom) with Gutenberg 19.4.0 and I don't see the "blinking" anymore.

I've also tested a simple site using the sticker gutenberg-edge v19.4.0-rc1 and I confirm that version of Gutenberg fixes the issue. You can add the Sticker gutenberg-edge to try it.

It seems that Gutenberg had an issue that cleared the dom when searching and that produced a conflict with some of our custom code. I'll see if I can find where it conflicts in WPcom side.

@donnapep
Copy link
Contributor

donnapep commented Oct 9, 2024

@sejas Our team is currently on the Gutenberg rotation. The plan is to release Gutenberg 19.4.0 next week, but @Imran92 can confirm. 🙂

@donnapep donnapep moved this from Triaged to Needs Core/3rd Party Fix in Automattic Prioritization: The One Board ™ Oct 9, 2024
@obenland
Copy link
Member

obenland commented Oct 9, 2024

@donnapep Can we accelerate shipping that update? Please feel free to pull in @Automattic/bespin and @Automattic/caribou folks as needed. A Blocker-level issue should be fixed as soon as we can.

@Imran92
Copy link
Contributor

Imran92 commented Oct 10, 2024

Hi @obenland 👋

I've already released v19.4.0 on simple edge sites.

Posted a CFT here pdtkmj-321-p2 and cross-posted to Nexus, Bespin and Caribou for quick turnaround.

I'll try to release before Thursday EOD to avoid releasing on Friday if everything goes as expected.

Thanks!

cc: @donnapep

@Imran92
Copy link
Contributor

Imran92 commented Oct 11, 2024

v19.4.0 is released on simple sites.

The release build for AT is also in the right repo. AT will pull it following their schedule [p9o2xV-3Ov-p2#comment-8716]

Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • p9o2xV-3Ov-p2#comment-8716

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Oct 11, 2024
@obenland
Copy link
Member

Thank you for getting it out before the weekend @Imran92!

@donnapep
Copy link
Contributor

Retested on both Simple and Atomic and confirm that this has been fixed. 🥳

@github-project-automation github-project-automation bot moved this from Needs Core/3rd Party Fix to Done 🎉 in Automattic Prioritization: The One Board ™ Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. Groundskeeping Issues handled through Dotcom Groundskeeping rotations Needs triage Ticket needs to be triaged [Platform] Atomic [Platform] Simple [Pri] BLOCKER Requires immediate attention. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Type] Bug
Development

No branches or pull requests

6 participants