Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: v19.6.x plugin upgrade #95885

Closed
15 of 38 tasks
holdercp opened this issue Oct 30, 2024 · 27 comments
Closed
15 of 38 tasks

Gutenberg: v19.6.x plugin upgrade #95885

holdercp opened this issue Oct 30, 2024 · 27 comments
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". gutenberg-upgrade To be used to classify Gutenberg upgrade tracking issues and make it easier to list them [Type] Task

Comments

@holdercp
Copy link
Contributor

holdercp commented Oct 30, 2024

Previous upgrade: #95318
Release notes: v19.6.2

Install and activate

  • Install and activate v19.6.0-rc.1 on edge (######-code)
  • Install and activate v19.6.0-rc.2 on edge (######-code)
  • Install and activate v19.6.0-rc.3 on edge (D165396-code)
  • Install and activate v19.6.0 on edge (######-code)
  • Activate v19.6.0 on production (######-code)
  • Request v19.6.0 AT upgrade (######-p2)
  • Install and activate v19.6.1 on edge (D165888-code)
  • Activate v19.6.1 on production (D165890-code)
  • Request v19.6.1 AT upgrade (######-p2)
  • Install and activate v19.6.2 on edge (D166369-code)
  • Activate v19.6.2 on production (D166370-code)
  • Request v19.6.2 AT upgrade (######-p2)
  • Install and activate v19.6.3 on edge (######-code)
  • Activate v19.6.3 on production (######-code)
  • Request v19.6.3 AT upgrade (######-p2)
  • Install and activate v19.6.4 on edge (######-code)
  • Activate v19.6.4 on production (######-code)
  • Request v19.6.4 AT upgrade (######-p2)

Testing

  • v19.6.0 Desktop viewport E2E
  • v19.6.0 Mobile viewport E2E
  • v19.6.0 WPCOM core (D165397-code)
  • v19.6.1 Desktop viewport E2E
  • v19.6.1 Mobile viewport E2E
  • v19.6.1 WPCOM core (######-code)
  • v19.6.2 Desktop viewport E2E
  • v19.6.2 Mobile viewport E2E
  • v19.6.2 WPCOM core (D166370-code)
  • v19.6.3 Desktop viewport E2E
  • v19.6.3 Mobile viewport E2E
  • v19.6.3 WPCOM core (######-code)
  • v19.6.4 Desktop viewport E2E
  • v19.6.4 Mobile viewport E2E
  • v19.6.4 WPCOM core (######-code)

Publish internal announcements

  • Slack: #wpcom-happy-announce - p1731684434115899-slack-CB0B2G43X
  • P2: wpcomhappy - p7DVsv-lHA-p2

Wrap-up

Blockers 🤷‍♀️

None

Other Issues 🐛

Issues transferred from previous release(s)

  • A bug was reported in p1729012544736219-slack-CBTN58FTJ that appeared after the v19.4.0 release. It seemed minor but it's worth following up with if there's time.
  • Not able to edit embedded blocks/ Block toolbar not visible in the Editor #95944 was reported shortly after v19.5.0 was released. v19.5.0 was reverted because of a bug and v19.5.1 is staged for deployment. v19.5.1 might fix the issue reported here but I was unable to reproduce on v19.5.0 so it might have been a fluke when an old page is edited after a GB update. It's worth following up on if there's time.

cc @Automattic/gutenberg-upgrades @Automattic/cylon

@holdercp holdercp added [Type] Task gutenberg-upgrade To be used to classify Gutenberg upgrade tracking issues and make it easier to list them labels Oct 30, 2024
Copy link

Automated update:
Added tasks for v19.6.0-rc.2

Copy link

Automated update:
Added tasks for v19.6.0-rc.3

Copy link

Automated update:

  • v19.6.0-rc.3 activation on edge marked as complete.
  • Release notes updated to v19.6.0-rc.3
  • Updated the diff used for v19.6.0-rc.3 core tests

@xavier-lc xavier-lc self-assigned this Nov 6, 2024
@xavier-lc
Copy link
Contributor

There's a buggy behavior with write/design mode making some template blocks unable to interact with, I'm trying to investigate:

WordPress/gutenberg#66463
WordPress/gutenberg#66802
WordPress/gutenberg#66803

@xavier-lc
Copy link
Contributor

xavier-lc commented Nov 7, 2024

I've identified WordPress/gutenberg#65945 (commit WordPress/gutenberg@fa8b36f) as the first PR where the List View content doesn't change when switching between the Write and Design modes.

@xavier-lc
Copy link
Contributor

xavier-lc commented Nov 7, 2024

A fix for WordPress/gutenberg#66463 is ready on WordPress/gutenberg#66833.

Update: That fix was for the the bug of the list view content not changing when switching between write and design modes. The original issue still persists (Template part selecting and editing unavailable in “Write” mode), the root cause for that was detected as well: WordPress/gutenberg#66463 (comment)

@xavier-lc
Copy link
Contributor

Created a new issue about groups unable to be expanded on List View, reported on p1731021532764149/1730732910.389969-slack-CB0B2G43X.

Copy link

Automated update:
Added tasks for v19.6.1

@synora
Copy link
Contributor

synora commented Nov 9, 2024

v19.6.0 and v19.6.1 seem to be causing a similar issue where items within a Group Block cannot be edited.

Screen.Recording.2024-11-09.at.8.27.55.AM.mov

Disabling Gutenberg allows the user to access the Form Block nested within a Group Block.

Reported in 9015639-zen.
The live site is on v19.6.0 and staging is on v19.6.1.

The Slack report at p1731159809368739-slack-C03TY6J1A

Copy link

github-actions bot commented Nov 9, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • 9015639-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Nov 9, 2024
@xavier-lc
Copy link
Contributor

@synora do you have reproduction steps for the issue so I can try to debug it?

@mgozdis
Copy link

mgozdis commented Nov 11, 2024

@xavier-lc I was helping @synora with that ticket. I could reproduce the issue on their live site like this:

  1. Pages > Add New Page
  2. Click Add New Page button and select Contact under "Featured"
  3. Select "Center heading with contact form"
  4. Attempt to click any of the field names and see they aren't editable.

Worth noting is the issue does not exist if we use an unmanaged version of the plugin and is specific to the versions on Dotcom possibly since 19.5.0. Using an unmanaged version of 19.6.1 and the page with the issue can be edited fine and is no longer reproducible.

@xavier-lc
Copy link
Contributor

I could reproduce the issue on their live site like this:

Thanks @mgozdis. My question was more if it was possible to reproduce the issue on any site from a scratch, in order to debug it.

Using an unmanaged version of 19.6.1 and the page with the issue can be edited fine and is no longer reproducible.

It's goo to know that, thanks!

@xavier-lc
Copy link
Contributor

The Gutenberg simple E2E tests edge (mobile) passed successfully! View build
The Gutenberg simple E2E tests edge (desktop) passed successfully! View build

@synora
Copy link
Contributor

synora commented Nov 12, 2024

Thanks for replying while I was AFK, @mgozdis.
@xavier-lc, at the time of testing, I couldn't reproduce it on my test site. However, that was before we discovered the blocks work using an unmanaged version of 19.6.1. I was using 19.5.0.

While I can no longer reproduce the issue, you'd want to create a new page and insert a 2 Column Block with text on one side and a contact form on the other. Then, group the parent Column Block and the column that contains the contact form. Save your changes, refresh your screen, and try to edit the form. You may need to ungroup them all in order to edit.

I'll try posting the video again, as the one in my comment above isn't working for me at the moment:

Screen.Recording.2024-11-09.at.8.27.55.AM.mov

One thing I noticed happening to that user's site is that initially, their page is a 2 Column Block layout. When you ungroup the parent Column Block, all column blocks disappear.

@xavier-lc
Copy link
Contributor

While I can no longer reproduce the issue, you'd want to create a new page and insert a 2 Column Block with text on one side and a contact form on the other. Then, group the parent Column Block and the column that contains the contact form. Save your changes, refresh your screen, and try to edit the form. You may need to ungroup them all in order to edit.

I couldn't reproduce it either, the form is editable after reload.

@xavier-lc
Copy link
Contributor

I was about to deploy v19.6.1 on production simple sites, but @david-binda noticed that there's a regression that allows comments to be posted on closed posts. (See slack p1731515367049229/1731510987.907329-slack-C4GAP2RHD)

@xavier-lc
Copy link
Contributor

xavier-lc commented Nov 13, 2024

Asked the folks on team IO for help (p1731517814154939-slack-C02A41GCS) and @ellatrix has set up a fix PR: WordPress/gutenberg#66976

Copy link

Automated update:
Added tasks for v19.6.2

Copy link

Automated update:

  • v19.6.2 activation on edge marked as complete.
  • Release notes updated to v19.6.2
  • Updated the diff used for v19.6.2 core tests

@xavier-lc
Copy link
Contributor

Copy link

Automated update:

  • v19.6.2 activation on production marked as complete.
  • Release notes updated to v19.6.2

@xavier-lc
Copy link
Contributor

Gutenberg: Remove unused v19.1.0 - D166405-code

Copy link

Automated update:
v19.6.2 is available at https://github.com/Automattic/gutenberg-dotcom-woa-releases/releases/tag/v19.6.2 for AT to pick up.

Copy link

Automated update:
Added tasks for v19.6.3

Copy link

Automated update:
Added tasks for v19.6.4

Copy link

Automated update:
v19.6.4 is available at https://github.com/Automattic/gutenberg-dotcom-woa-releases/releases/tag/v19.6.4 for AT to pick up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". gutenberg-upgrade To be used to classify Gutenberg upgrade tracking issues and make it easier to list them [Type] Task
Projects
None yet
Development

No branches or pull requests

4 participants