Block Editor: Fix stale dependencies of selectors depending on editorTool preference #66833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `state.editorMode` reducer was removed in 65945 in favour of persisted user preferences. Selector `__unstableGetEditorMode` should be used instead. This commit fixes a bug wherein changes to `editorTool` don't trigger a re-render of the block list view. See: #65945
mcsf
added
[Type] Bug
|
Size Change: +61 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2c9d260. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11734772858
|
|
You are magic 🧙🏼 Works great for me, both when switching in the editor and in leaving/returning: write.mode.magic.mov |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @xavier-lc. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
annezazu
approved these changes
Nov 7, 2024
xavier-lc
approved these changes
Nov 7, 2024
38 tasks
youknowriad
approved these changes
Nov 7, 2024
…be registry selectors
|
Pushed a commit to fix the failing tests. It looks like because |
ellatrix
reviewed
Nov 8, 2024
| @@ -116,7 +117,7 @@ export const getEnabledClientIdsTree = createSelector( | |||
| state.blockEditingModes, | |||
| state.settings.templateLock, | |||
| state.blockListSettings, | |||
| state.editorMode, | |||
| __unstableGetEditorMode( state ), | |||
There was a problem hiding this comment.
This seems wrong still, shouldn't it use select( store )?
There was a problem hiding this comment.
Pushed a commit, does that look better?
There was a problem hiding this comment.
Looks like some tests need to be updated now.
There was a problem hiding this comment.
Thanks for the fixes, @talldan! This was an end-of-day PR for me, and I didn't wait for the tests...
There was a problem hiding this comment.
No worries, thought I'd help out on the night shift, as it looked fairly urgent 😄
cbravobernal
added
the
Backport to Gutenberg Minor Release
mcsf
added a commit
that referenced
this pull request
Nov 8, 2024
…Tool preference (#66833) * Block Editor: Fix dependencies of selectors depending on editorTool pref The `state.editorMode` reducer was removed in 65945 in favour of persisted user preferences. Selector `__unstableGetEditorMode` should be used instead. This commit fixes a bug wherein changes to `editorTool` don't trigger a re-render of the block list view. * Update selectors that use __unstableGetEditorMode as a dependency to be registry selectors * Update other selector * Fix tests --------- Co-authored-by: Daniel Richards <[email protected]>
mcsf
removed
the
Backport to Gutenberg Minor Release
|
Cherry-picked for 19.6.1. |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…Tool preference (WordPress#66833) * Block Editor: Fix dependencies of selectors depending on editorTool pref The `state.editorMode` reducer was removed in 65945 in favour of persisted user preferences. Selector `__unstableGetEditorMode` should be used instead. This commit fixes a bug wherein changes to `editorTool` don't trigger a re-render of the block list view. * Update selectors that use __unstableGetEditorMode as a dependency to be registry selectors * Update other selector * Fix tests --------- Co-authored-by: Daniel Richards <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66463
What?
This fixes a bug wherein changes to the Write/Design mode selection don't trigger a re-render of the block list view.
How?
The
state.editorModereducer was removed in #65945 in favour of persisted user preferencecore.editorTool. Selector__unstableGetEditorModeshould be used instead. This fix correctly adopts the latter as a dependency of selectorsgetEnabledClientIdsTreeandgetInsertBlockTypeDependants.Testing Instructions
See parent issue. In short: in the site editor, keep the list view open, then switch between Write and Design modes, and confirm that the list view updates to show/hide certain blocks, such as template parts.