Add back eslint max-len of 140 characters #12415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
Framework
[Status] Needs Review
nb
approved these changes
Mar 22, 2017
nb
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
Good call, Marin - I missed that when merging #6945 |
oandregal
approved these changes
Mar 22, 2017
|
Marin, now that we are here, do you mind adding back these other rules? I didn't want to commit in the PR directly myself, to avoid any conflicts. |
|
Sure, but let's address that in a separate PR, @nosolosw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6945 was a great effort that cleaned up a lot and will allow us to push only clean and compatible code. However, it also removed the
max-lenESLint rule, which was previously set to 140 characters. The default value is 100, which means that it'll blow up almost everywhere - we have a ton of code with lines between 101 and 140 characters.This PR adds back that rule, which I think is necessary. Unless there was a discussion about reducing the max length of lines to 100 characters, and I missed it?