Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar: fixup styles to work without the CSS reset #45379

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented Sep 3, 2020

While playing with the Gutenlypso prototype in #44801, I noticed a broken sidebar:

Screenshot 2020-09-03 at 14 59 32

It's caused by missing styles that used to be directly on the ul and h2 elements in the CSS reset. This PR adds them to the specific .sidebar_... rules.

How to test:
On master, this change shouldn't have any observable effects. In the #44801 branch:

  • the horizontal identation of sidebar items should be removed
  • the vertical space between items should be smaller
  • after clicking on an expandable item, e.g., "Site", you shouldn't see a blue focus ring (added by default on the <h2 tabindex=0> that has been made interactive by the tabindex attr)

@jsnajdr jsnajdr added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Sidebar labels Sep 3, 2020
@jsnajdr jsnajdr self-assigned this Sep 3, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sidebar looks great with #44801 now 👍

🚢

@tyxla tyxla added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 3, 2020
@sarayourfriend
Copy link
Contributor

Thanks for doing this @jsnajdr! It's also part of #45259.

@jsnajdr jsnajdr merged commit 18e5389 into master Sep 4, 2020
@jsnajdr jsnajdr deleted the fix/resetless-sidebar-styles branch September 4, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants