Remove isolated block editor #64097
Merged
Remove isolated block editor #64097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
noahtallen
commented
May 27, 2022
| @@ -42,6 +27,22 @@ logFilters: | |||
| level: discard | |||
| - pattern: "wp-calypso@workspace:. provides react-dom (pf5aa8) with version 17.0.2, which doesn't satisfy what @types/wordpress__block-editor and some of its descendants request" | |||
| level: discard | |||
| - pattern: "calypso@workspace:client provides react (pb0cb8) with version 17.0.2, which doesn't satisfy what @wordpress/block-editor and some of its descendants request" | |||
There was a problem hiding this comment.
No clue why this is an issue now, but we can't get around it unless Gutenberg drops a transitive dependency.
fullofcaffeine
added
the
caused-by-gutenberg-upgrade
github-actions
bot
removed
the
[Status] Needs Review
|
Came late to this, but just wanted to say thanks for cleaning it up 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
The isolated block editor package has given us significant trouble with WordPress monorepo updates over the past several months. This time, it's completely blocking the release of Gutenberg to dotcom for an interesting chain of issues stemming from the removal of an experimental method in Gutenberg.
It's only used for an experiment @sarayourfriend did a year or two ago with Gutenberg in the Reader. We have no plans to actively continue work on that experiment, so it's fair to remove the code completely at this point. This lets us remove the isolated block editor package from our dependencies and that should unblock the gutenberg release.
Related discussion: p1653583842699789-slack-CBTN58FTJ
Testing instructions
Related to #64093