Hide the Welcome Tour in the site editor view mode

[okmttdhr]

Closes #72533

Proposed Changes

Hide the Welcome Tour in the site editor view mode (referred to as the "Browse mode" in the original issue) since the tour doesn’t explain how to use the view mode (it does when in editor mode). Hide it until we create the tour for the view mode.

Screen.Recording.2566-03-24.at.16.21.23.mov

Testing Instructions

• Sandbox a site
• Run the install-plugin.sh etk update/hide-wolcome-tour command in your sandbox
• Access wordpress.com/site-editor/[ THE SITE SLUG ]
• Click on Edit or on the canvas to enter the edit mode
• Click on Welcome Guide from the Options panel (the three dots menu on the top right) to show it

• Click on the WordPress logo to enter the view mode
• Verify the Welcome Tour appears only in the edit mode

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-59601

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-59601&env=jetpack

[matticbot]

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit update/hide-wolcome-tour on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

[okmttdhr]

We needed to use unlock to get the "site editor's mode" (view, edit, etc.) since the select( 'core/edit-site' ).getCanvasMode is still a private API.

• getCanvasMode selector: https://github.com/WordPress/gutenberg/blob/4b4b4ca96f201a06cf7fffb9921041957f070fac/packages/edit-site/src/store/private-selectors.js#L8
• It is used with unlock in Gutenberg; https://github.com/WordPress/gutenberg/blob/4b4b4ca96f201a06cf7fffb9921041957f070fac/packages/edit-site/src/components/sidebar-navigation-screen-template/index.js#L17

What do you think about using @wordpress/private-apis? @Automattic/lego

If this is not preferred, I think we better wait until getCanvasMode get stable than implement this on our own.

[okmttdhr]

I assigned @Automattic/lego as a reviewer because I would like you to look at this earlier 🙂 If it looks good, I'll get to work on tests, etc.

[arthur791004]

I assume it's good to use it except we have another stable way to get the canvas mode. Tested and changes look good 🙂

[miksansegundo]

I found these:

• Open issue: Separate Private APIs from Experimental APIs
• Coding guidelines: Use the lock() and unlock() API from @wordpress/private-apis to privately export almost anything

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[miksansegundo]

LGTM 👍

I tested on a simple site via sandbox and on an atomic site uploading the ETK plugin (v3.58617) from Teamcity.

On an atomic site, we don't show the same Welcome guide so the changes doesn't apply.

[okmttdhr]

@miksansegundo Thanks for testing and the merge!

[miksansegundo]

Hi @okmttdhr! It's a good idea to find a way to test for this private API, as you mentioned.