Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProgressBarAutomationPeer #10275

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Add ProgressBarAutomationPeer #10275

merged 2 commits into from
Feb 9, 2023

Conversation

Takoooooo
Copy link
Contributor

What does the pull request do?

Started to add automation peers for our controls,the main goal is to have all controls covered with the automation peers. ProgressBarAutomationPeer is a port of WPF version of it in general. I am planning to add integration tests for each control but i can't think of any useful integration tests for progress bars,if someone would have any good ideas i will implement the tests. Tested that ProgressBar plays well now with Windows and MacOS narrators.

Fixed issues

Part of #10143

@Takoooooo Takoooooo requested a review from grokys February 8, 2023 22:12
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0029759-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 enabled auto-merge February 8, 2023 23:41
@maxkatz6 maxkatz6 merged commit 0035fb6 into master Feb 9, 2023
@maxkatz6 maxkatz6 deleted the progressBar-automationPeer branch February 9, 2023 00:08
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0029765-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@robloo
Copy link
Contributor

robloo commented Feb 9, 2023

I thought we needed to add a header for code included from other projects?

@maxkatz6
Copy link
Member

maxkatz6 commented Feb 9, 2023

@robloo good question. I haven't paid attention as this code is as simple as it can be. And other automation classes (supposedly also from there) don't have any headers.

Upd: Seems like there is no issue as we have WPF in our NOTICE.md https://github.com/AvaloniaUI/Avalonia/blob/master/NOTICE.md#wpf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants