Make data templates work again with MenuItem. #10836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `MenuItem` is a `HeaderedSelectingItemsControl` not a `HeaderedItemsControl` so need to separate logic for that case when preparing items - Added `HeaderTemplate` to `HeaderedSelectingItemsControl ` - Tweaked logic for selecting header templates: parent's `ItemTemplate` should be used if set (cross-checked with WPF) - Update menu templates to bind to menu item's `HeaderTemplate` Fixes #10626 Fixes #10718
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Mar 29, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I think this solves my question in #10195 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Menus stopped working correctly with data templates after #9677, a few fixes were needed to make them work again:MenuItemis aHeaderedSelectingItemsControlnot aHeaderedItemsControlso need to separate logic for that case when preparing itemsHeaderTemplatetoHeaderedSelectingItemsControlItemTemplateshould be used if set (cross-checked with WPF)HeaderTemplateFixed issues
Fixes #10626
Fixes #10718