Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressbar Updates #11195

Merged
merged 2 commits into from
Apr 30, 2023
Merged

Progressbar Updates #11195

merged 2 commits into from
Apr 30, 2023

Conversation

robloo
Copy link
Contributor

@robloo robloo commented Apr 30, 2023

What does the pull request do?

In auditing ProgressBar for #9944 it was found to be a very outdated control. Two things really needed to be fixed:

  1. Comments added (where I knew what they should be)
  2. TemplateProperties renamed to TemplateSettings which is the modern convention and used in other controls like SplitView.

This PR fixes those two issues.

The single DirectProperty Percentage is already correct as a read-only calculated property so wasn't changed. All DirectProperty usage in the template settings class was ignored as out-of-scope (animation-related properties are being skipped anyway).

What is the updated/expected behavior with this PR?

See above

How was the solution implemented (if it's not obvious)?

See code

Checklist

Breaking changes

Yes, for styles renamed ProgressBarTemplateProperties to ProgressBarTemplateSettings. This needed to be done for 11.0 API finalization anyway. Style and control libraries will need to update.

Obsoletions / Deprecations

None

Fixed issues

Fixes #10707

@maxkatz6 maxkatz6 enabled auto-merge April 30, 2023 16:21
@maxkatz6 maxkatz6 added this pull request to the merge queue Apr 30, 2023
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0034087-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

Merged via the queue into AvaloniaUI:master with commit 3b2c713 Apr 30, 2023
@robloo robloo deleted the progressbar-updates branch April 30, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProgressBarTemplateProperties should be named ProgressBarTemplateSettings
3 participants