Fix not working hotkey on a custom control. closes #12323 #12347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Registration of hotkeys for controls that do not implement
Avalonia.Input.IClickableControl
but implementAvalonia.Input.ICommandSource
is possible now.What is the current behavior?
Current behavior is broken/regression compare to Avalona v0.10. Currently, in Avalonia v11, you can declare type
HotKeyedTextBox
inherited fromAvalonia.Controls.TextBox
with implementedHotKey
property, but it will not work, but in Avalonia v0.10 it will work. Example with working hotkey registration for custom typeHotKeyedTextBox
inherited fromAvalonia.Controls.TextBox
for Avalonia v0.10.21 and not working hotkey registration for custom typeHotKeyedTextBox
inherited fromAvalonia.Controls.TextBox
for Avalonia V11 here. Curren behavior was created by #7500.What is the updated/expected behavior with this PR?
When declaring of custom control with proper implementation of
HotKey
property possible and hotkey working as expected, like in Avalonia v0.10.How was the solution implemented (if it's not obvious)?
In
Avalonia.Controls.HotKeyManager.HotKeyManager()
(static constructor) condition has been changed fromif (control is not IClickableControl)
toif (control is not IClickableControl and not ICommandSource)
.Checklist
Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
Fixes #12323