-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DataContext not getting GC'd/Finalized. closes #12123 #12430
Conversation
You can test this PR using the following package version. |
Can you check if it also fixes #8240? |
You can test this PR using the following package version. |
I will take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
What does the pull request do?
Now
Window.DataContext
getting GC'd/Finalized after window close andGC.Collect
call.What is the current behavior?
Window.DataContext
not getting GC'd/Finalized after window close andGC.Collect
call.What is the updated/expected behavior with this PR?
Window.DataContext
getting GC'd/Finalized after window close andGC.Collect
call.How was the solution implemented (if it's not obvious)?
To
Avalonia.Controls.TopLevel.HandleClosed
method body was addedAvalonia.Controls.TopLevel.StopRendering
method call.Checklist
Breaking changes
None.
Obsoletions / Deprecations
None.
Fixed issues
#12123