Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataContext not getting GC'd/Finalized. closes #12123 #12430

Merged
merged 6 commits into from
Aug 6, 2023
Merged

Fix DataContext not getting GC'd/Finalized. closes #12123 #12430

merged 6 commits into from
Aug 6, 2023

Conversation

flexxxxer
Copy link
Contributor

@flexxxxer flexxxxer commented Aug 3, 2023

What does the pull request do?

Now Window.DataContext getting GC'd/Finalized after window close and GC.Collect call.

What is the current behavior?

Window.DataContext not getting GC'd/Finalized after window close and GC.Collect call.

What is the updated/expected behavior with this PR?

Window.DataContext getting GC'd/Finalized after window close and GC.Collect call.

How was the solution implemented (if it's not obvious)?

To Avalonia.Controls.TopLevel.HandleClosed method body was added Avalonia.Controls.TopLevel.StopRendering method call.

Checklist

Breaking changes

None.

Obsoletions / Deprecations

None.

Fixed issues

#12123

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038306-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@timunie
Copy link
Contributor

timunie commented Aug 5, 2023

Can you check if it also fixes #8240?

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038328-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@flexxxxer
Copy link
Contributor Author

Can you check if it also fixes #8240?

I will take a look

@flexxxxer
Copy link
Contributor Author

Can you check if it also fixes #8240?

No, when MS Windows Narrator is turn ON. I won't be making fix changes #8240 in this pull request

@flexxxxer flexxxxer marked this pull request as ready for review August 5, 2023 18:17
@maxkatz6 maxkatz6 enabled auto-merge August 6, 2023 00:38
Copy link
Member

@maxkatz6 maxkatz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@maxkatz6 maxkatz6 added this pull request to the merge queue Aug 6, 2023
Merged via the queue into AvaloniaUI:master with commit d772ea8 Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants