Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AvaloniaVS can not resolve resource relative path in Previewer #12473

Conversation

workgroupengineering
Copy link
Contributor

What does the pull request do?

Fix baseUri

What is the current behavior?

When using xaml like this:

<Application xmlns="https://github.com/avaloniaui"
             xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
             xmlns:local="using:ACTest"
             x:Class="ACTest.App">
  <Application.DataTemplates>
    <local:ViewLocator/>
  </Application.DataTemplates>

  <Application.Resources>
    <ResourceDictionary>
      <ResourceDictionary.MergedDictionaries>
        <ResourceInclude Source="Icons.axaml" />
      </ResourceDictionary.MergedDictionaries>

    </ResourceDictionary>

  </Application.Resources>

  <Application.Styles>
    <FluentTheme/>
  </Application.Styles>
</Application>

When opening Designer, the following error is reported

Unable to resolve XAML resource "avares://ACTest/Designer/Icons.axaml" in the "ACTest" assembly. Line 12, position 26.	ACTest	C:\Users\Utente\Source\Repos\ACTest\ACTest\App.axaml	12	

What is the updated/expected behavior with this PR?

No error is raised

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes AvaloniaUI/AvaloniaVS#324

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038352-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Aug 29, 2023
Merged via the queue into AvaloniaUI:master with commit 7b9887d Aug 29, 2023
@workgroupengineering workgroupengineering deleted the features/Tools/Previewer/AvaloinaVS_Issue324 branch August 29, 2023 09:37
@grokys grokys added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Oct 2, 2023
grokys pushed a commit that referenced this pull request Oct 2, 2023
…eviewer/AvaloinaVS_Issue324

fix: AvaloniaVS can not resolve resource relative path in Previewer
@grokys grokys added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unamble Resolve Resource at Desgin Time
4 participants