Enhanced Clipping and Rendered Visuals Tracking in ServerCompositionVisual #12568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition, the ServerCompositionVisual now tracks changes to the clip property, allowing for re-calculation when the clip is altered.
…d added relevant unit tests in CompositorInvalidationClippingTests. The new tests ensure that visuals that are not in dirty rect are rendered correctly with different ClipToBounds and Clip geometry parameters.
|
You can test this PR using the following package version. |
kronic
reviewed
Aug 17, 2023
| @@ -2,5 +2,7 @@ namespace Avalonia.Rendering.Composition; | |||
|
|
|||
| internal interface ICompositionTargetDebugEvents | |||
| { | |||
| public int RenderedVisuals { get; } | |||
kekekeks
approved these changes
Aug 17, 2023
|
Please address that "remove public" comment. Otherwize LGTM |
…als property in the ICompositionTargetDebugEvents interface.
|
@dotnet-policy-service agree company="JetBrains GmbH" |
|
You can test this PR using the following package version. |
…to fixes/clip-bounds-invalidate
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR enhances the clipping calculation within the
ServerCompositionVisualby takingClip.Boundsinto account. The primary goal is to ensure that visuals, which are not within a dirty rect, are not re-rendered when differentClipToBoundsandClipgeometry parameters are set.What is the current behavior?
Currently,
ServerCompositionVisual.Rendermethod do nothing if boundaries of the visual do not intersect withDirtyRect. This approach effectively minimizes the areas of the scene redrawn, especially when a single element is invalidated. However, this optimization is only effective whenClipToBounds=true. While havingClipToBounds=falsebut setting an explicitClipis valid, it's not considered in the current implementation.What is the updated/expected behavior with this PR?
After this PR, the
ServerCompositionVisualwill also consider changes to theClipproperty, allowing it to recalculate when the clip is altered. This ensures accurate rendering even whenClipToBounds=falsebut an explicitClipis set.How was the solution implemented (if it's not obvious)?
Clip.Boundswas considered in the clipping calculation withinServerCompositionVisual.CompositorInvalidationClippingTeststo verify the correct rendering of visuals not in the dirty rect with differentClipToBoundsandClipgeometry parameters.ServerCompositionVisualwas introduced.Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues