Fix for TextBlock.TextDecorations not inheriting down to inlines. #12624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
Gillibald
approved these changes
Aug 22, 2023
grokys
pushed a commit
that referenced
this pull request
Sep 28, 2023
Fix for TextBlock.TextDecorations not inheriting down to inlines.
grokys
added
the
backport-candidate-11.0.x
grokys
pushed a commit
that referenced
this pull request
Oct 2, 2023
Fix for TextBlock.TextDecorations not inheriting down to inlines.
grokys
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
The PR fixes a bug and updates logic so
TextBlock.TextDecorationswill apply even whenTextBlock.Inlinesare used.What is the current behavior?
TextDecorations, unlike nearly all other text related properties, do not currently inherit down fromTextBlocktoInlines.TextDecorationsDO currently work ifTextBlock.Textis specified though.What is the updated/expected behavior with this PR?
The updated behavior allows
TextDecorationsto be inherited down into inlines like other text-related properties.How was the solution implemented (if it's not obvious)?
Updated
Inline.TextDecorationsto be an attached inherited property like otherTextElementproperties (FontSize,FontWeight, etc.). UpdatedTextBlockto add owner that attached property.Checklist
Breaking changes
Shouldn't be any.
Obsoletions / Deprecations
None
Fixed issues
None