Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offset expression animation #13071

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

Meloman19
Copy link
Contributor

What does the pull request do?

  1. Fixing if condition in the Invalidate method in the ServerObjectSubscriptionStore.
  2. Add Vector3D to VariantPropertyTypes.

What is the current behavior?

  1. After first property reading, invalidation never happens.
  2. CompositionGenerator ignoring Vector3D type and properties of this type don't added to GetPropertyForAnimation.

What is the updated/expected behavior with this PR?

ExpressionAnimation with reference to Vector3D property will worked.

Fixed issues

Fixes #12939

@Meloman19 Meloman19 changed the title Fix/offset expression animation Fix offset expression animation Sep 28, 2023
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0040158-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@Meloman19
Copy link
Contributor Author

@dotnet-policy-service agree

@maxkatz6 maxkatz6 added this pull request to the merge queue Sep 29, 2023
Merged via the queue into AvaloniaUI:master with commit 7479f53 Sep 29, 2023
5 checks passed
@Meloman19 Meloman19 deleted the fix/OffsetExpressionAnimation branch September 29, 2023 17:17
@grokys grokys added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Oct 2, 2023
grokys pushed a commit that referenced this pull request Oct 2, 2023
* Fix ServerObject subscription Invalidate

* Add Vector3D property type to CompositionGenerator

---------

Co-authored-by: Meloman19 <[email protected]>
@grokys grokys added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExpressionAnimation not work for ReferenceParameter.Offset
4 participants