Fix watermark alignment of TextBox in the Simple theme #5802 #13295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
approved these changes
Oct 17, 2023
|
Please consider adding the "hacktoberfest-accepted" label to this PR. |
maxkatz6
added
hacktoberfest-accepted
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Dec 5, 2023
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Adds horizontal and vertical alignment template bindings so that the watermark of the
TextBoxin the simple theme is not affected by the defaultTextBlockstyle.What is the current behavior?
The
TextBoxwatermark will have the same alignment as the style for a genericTextBlock. See #5802What is the updated/expected behavior with this PR?
Fix the alignment of
TextBoxwatermarks in the simple theme.How was the solution implemented (if it's not obvious)?
Two simple
TemplateBindingfrom the Horizontal/VerticalContentAlignment of theTextBoxto the watermarkTextBlockHorizontal/VerticalAlignment.Checklist
Unsure if this requires a test case. I've not seen any test cases related to the Simple theme, so please advise if there is a place to add unit tests.
Breaking changes
Probably not.
Fixed issues
Fixes #5802