Avoid Adreno DXGI adapter on Win-ARM devices #13538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
the
backport-candidate-11.0.x
|
So this is a driver issue in the end? |
kekekeks
reviewed
Nov 8, 2023
| .First().adapter.CloneReference(); | ||
| .OrderByDescending(x => | ||
| // Put adreno in lower priority - it's broken in Avalonia. | ||
| x.name.Contains("adreno") ? -1 |
There was a problem hiding this comment.
Checking for nvidia/amd gpus is probably unwanted there
maxkatz6
commented
Nov 10, 2023
src/Windows/Avalonia.Win32/OpenGl/Angle/AngleWin32EglDisplay.cs
Outdated
Show resolved
Hide resolved
jmacato
approved these changes
Dec 1, 2023
maxkatz6
added a commit
that referenced
this pull request
Dec 5, 2023
* Avoid adreno DXGI adapter on Win-ARM devices * Update src/Windows/Avalonia.Win32/OpenGl/Angle/AngleWin32EglDisplay.cs
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Ignoring Adreno DXGI adapter seems to fix Avalonia running on win-arm devices. On my arm device, the second adapter to be used is Microsoft Basic Renderer which doesn't have these issues. I would expect it to be slower, but I don't really want to solve these problems right now.
While it's probably not the best solution, an application still is feature complete (like, winui composition works fine).
Fixed issues
Fixes #10405