Ignore mouse move when left window #13724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltetak
commented
Nov 24, 2023
Comment on lines
-44
to
+48
| if (args.Type is RawPointerEventType.LeaveWindow or RawPointerEventType.NonClientLeftButtonDown | ||
| or RawPointerEventType.TouchCancel or RawPointerEventType.TouchEnd | ||
| && _currentPointer is var (lastPointer, lastPosition)) | ||
| if (args.Type is RawPointerEventType.LeaveWindow or RawPointerEventType.NonClientLeftButtonDown | ||
| or RawPointerEventType.TouchCancel or RawPointerEventType.TouchEnd) | ||
| { | ||
| _currentPointer = null; | ||
| ClearPointerOver(lastPointer, args.Root, 0, PointToClient(args.Root, lastPosition), | ||
| new PointerPointProperties(args.InputModifiers, args.Type.ToUpdateKind()), | ||
| args.InputModifiers.ToKeyModifiers()); | ||
| if (_currentPointer is var (lastPointer, lastPosition)) | ||
| { |
There was a problem hiding this comment.
we don't want to clear PointerOver (since there is none) - but we also do not want to set any later in this conditions chain.
maxkatz6
approved these changes
Dec 1, 2023
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Dec 5, 2023
#Conflicts: # src/Avalonia.Base/Input/PointerOverPreProcessor.cs
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fix a bug when you resize or move a window and still receive PointerOver mouse events.
It is an Avalonia 11 regression from my previous PR #7804.
What is the current behavior?
Resize and move a window and see that seemingly random controls receive PointerOver events. This triggers mouse over style changes but also tooltips appearing, etc.
What is the updated/expected behavior with this PR?
no PointerOver events
cc: @maxkatz6 This may interest you, thanks.