Fix nth-child styles on virtualized lists
#13770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `IValueEntry.HasValue` and `ValueFrame.IsActive` properties could alter state, which meant that when inspecting objects with these properties in a debugger, the state got altered by observing it. Make them methods.
Break the rules in this case. Fixes #12381
grokys
added
the
backport-candidate-11.0.x
maxkatz6
approved these changes
Nov 28, 2023
5 tasks
maxkatz6
added a commit
that referenced
this pull request
Dec 5, 2023
* Don't alter state in properties. The `IValueEntry.HasValue` and `ValueFrame.IsActive` properties could alter state, which meant that when inspecting objects with these properties in a debugger, the state got altered by observing it. Make them methods. * Deleted unused file. * Add failing test for #12381. * Use the index from the event in EvaluateIsActive. Break the rules in this case. Fixes #12381 --------- Co-authored-by: Max Katz <[email protected]>
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
#12381 occurs when there are multiple
nth-childstyles applied to a virtualized list.The fix is to always use the index from the
ChildIndexChangedEventArgsevent inNthChildActivator.EvaluateIsActive.The docs for
StyleActivatorBase.EvaluateIsActivesay:Which is good advice in general, however in this case we need to break the rule and use the value from the event subscription where possible instead of calling
IChildIndexProvider.GetChildIndex. This is because this event can be fired during the process of realizing an element of a virtualized list; in this case there may be more than onenth-childstyle on a the list item and when the other is re-evaluated, callingGetChildIndexmay not return the correct index as the element isn't yet realized."Bonus" fix
The
IValueEntry.HasValueandValueFrame.IsActiveproperties could alter state, which meant that when inspecting objects with these properties in a debugger, the state got altered by observing it. Make them methods, which makes debugging stuff like this a lot less frustrating! (Most of this PR is actually this change, the meat of the actual fix for #12381 is inNthChildActivator.)Fixed issues
Fixes #12381