Fix: TabItem.TabStripPlacement is not set for new tab items #13849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move TabItemStripPlacement assignment to PrepareContainerForItemOverride * remove excessive UpdateTabStripPlacement call on TabStripPlacementProperty.Changed
|
@dotnet-policy-service agree |
|
You can test this PR using the following package version. |
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
approved these changes
Dec 7, 2023
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Jan 17, 2024
* TabItem.TabStripPlacemenet should be correctly set * fix: TabItem.TabStripPlacemenet should be correctly set * move TabItemStripPlacement assignment to PrepareContainerForItemOverride * remove excessive UpdateTabStripPlacement call on TabStripPlacementProperty.Changed #Conflicts: # tests/Avalonia.Controls.UnitTests/TabControlTests.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Moves the
TabItem.TabStripPlacemntassignment to theTabControl.PrepareContainerForItemOverridemethod. The excessiveUpdateTabStripPlacementmethod call is also removed, because TabControl refreshes all its containers whenTabStripPlacementis changed.What is the current behavior?
After this fix, TabControl doesn't apply its TabStripPlacement to items that can be used as containers themselves (the
CreateContainerForItemOverridemethod is not called in this case).Checklist