Hackfix for calling SelectAll with SelectedItem binding #13868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grokys
added
bug
backport-candidate-11.0.x
maxkatz6
approved these changes
Dec 7, 2023
|
You can test this PR using the following package version. |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
You can test this PR using the following package version. |
grokys
added a commit
that referenced
this pull request
Dec 8, 2023
* Added failing tests for #13676. * Add hackfix for #13676. --------- Co-authored-by: Max Katz <[email protected]>
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
maxkatz6
added a commit
that referenced
this pull request
Jan 17, 2024
* Added failing tests for #13676. * Add hackfix for #13676. --------- Co-authored-by: Max Katz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
As described in #13676, calling
SelectAll()on aListBoxwith no current selection and a two-waySelectedIndexorSelectedItembinding in place, causesSelectAll()to fail. What was happening is:SelectAll()is calledSelectedIndex/SelectedItemproperty on theSelectionModelPropertyChangedto be raised forSelectedIndex/SelectedItemon theListBoxSelectedIndex/SelectedItem, even though this value hasn't changedSelectedIndex/SelectedItem's semantics are such that setting them clears all other selected itemsStep 6 is a bug in the binding system: we should not be writing an unchanged value back to the target due to a change in the source, and this will be fixed in the upcoming binding system refactor. However in the meantime, I think we need a hackfix as an interim solution. The easiest way to do this is to add the fix to
SelectionModel.Fixed issues
Fixes #13676